Repository navigation
Fix stale commit attribution in PR path overlap reports - #3104
Merged
Mister-Meeseeks merged 1 commit intoOct 17, 2026
Merged
Mister-Meeseeks merged 1 commit into
Mister-Meeseeks merged 1 commit into
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path overlap searches can currently attach commit B to a file list fetched at commit A: the file-pagination code checks the original head, then discards it before caching. A separately refreshed PR-body snapshot supplies the reported head.
Retain the file-list head, report the body head separately, and flag unverified joins. Coverage also names missing or mismatched inventories when no path matches, so an empty result cannot silently hide that gap. Online path queries refresh legacy headless file caches; offline or failed refreshes retain explicitly unbound evidence. Full file pagination, stale leads, body-only fetch costs and per-source atomic replacement remain covered.
Validation:
python3.12 -B -m unittest discover -s tests -p 'test_research_*.py' -v: 214 tests, OK with 18 native Linux/Windows skips on macOS.72380f027199199ed4b4dbfc252ec39163acc56c; an intentionally different body head is flagged. No full live file-index refresh is claimed.git diff --checkpasses.Task and overlap: canonical main
18aacb215fc3717b06be8ceb9fca62aeca0d3e99, priority revision 6, chooser seed5df01753e885c02e48a4482ad39d7a09(adversarial audit). Scope changed from the supplier-boundary card to a concrete source-binding counterexample in its prescribed coordination tool. Final overlap refresh at 2026-10-17 00:48 UTC covered 254 open PR bodies and 1,861 Discussion records with complete pagination; targeted all-state searches inspected the predecessor tooling. Sparse local notes and unsearched diffs remain limitations, not a novelty guarantee.Credit Douglas Colkitt's overlap/cache helper, Aaron Wang/navinor's #1623 path index, and ywz65's #2517 complete continuation paging. This patch adds the binding between file and body snapshots. Historical
overlap-path-indexandoverlap-discussion-batchingpins already differ from the base script; their frozen packages are unchanged, and their registered replays are not claimed. No mathematical supplier replay, new kappa or selected-frontier change.Arham Tahir, with substantial OpenAI Codex assistance. Apache-2.0; no independent human or formal review claimed.