Repository navigation
Fix retained-total output crashes in the partial-swap verifier - #3541
Open
SovereignSteak wants to merge 1 commit into
Open
SovereignSteak wants to merge 1 commit into
SovereignSteak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid retained-total outputs currently crash
SharedPointCircuit.verify():graph(6).verify()raisesValueErrorbecause the optimized digest writer unpacks every target as a triple. The h25 producer reached bymake verifyuses singleton targets for retained totals.Serialize the target's integer entries at their actual arity, preserving the historical compact JSON bytes and every support/topology assertion. Add whole-receipt comparisons against the pre-optimization verifier at h=6,8,10,25, the frozen h25 scalar receipt, and a negative control that substitutes an incomplete sum for a retained total.
Regenerate
partial-swap-network.jsonwith its existing generator: only the repaired source hash changes. Refresh the corresponding live pins in the two existing optimization suites; frozen baselines, source-provenance manifests and mathematical expectations remain unchanged.Validation: 16 focused tests pass; both registered optimization packages pass, including h46 equivalence and optimized-Python checks; the complete fresh h25 producer and copied CRT audit pass (96,273 matrix profiles). Details and hashes are in
docs/research/partial-swap-retained-total-fix.md.make verifypasses the repaired producer and geometry, then exits 2 at an independently confirmed pre-existing historical source-pin mismatch: the copied-fixed-reversed witness still pins the pre-optimizationshared.py. That frozen manifest is preserved. The full sweep and selected cold replay are not claimed to pass.No new κ, runtime gain, selected-record change, or complete theorem proof is claimed. Credits: Douglas R. Colkitt's underlying circuits, icekylinx's partial-swap adaptation, Wentao Li / VictorLiwentao's #2039 optimizations, and the h25 producer's credited predecessors. Prepared as SovereignSteak with OpenAI Codex assistance; existing licenses preserved.