Repository navigation
Accept the reviewed isolated-runner successor in reconciliation - #3688
Open
roger-sato wants to merge 1 commit into
Open
roger-sato wants to merge 1 commit into
roger-sato wants to merge 1 commit into
Conversation
roger-sato
marked this pull request as ready for review
October 18, 2026 14:51
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssertionSafetyRefresh.test_exact_accepted_successors_pass:check_batch932_filerejects the canonicalscripts/run_isolated_tests.pywithValueError: Changed integrated file: scripts/run_isolated_tests.py. The existing exact-successor list stops before three reviewed changes already present on main.ef5035e6216d39569da670f32b2717c870b23c418016fd134cc0a72649fb912aunder the original frozen batch932 predecessor. Preserve the original receipt, existing successors, test-file hashes and runner bytes. Unknown edits, a forged predecessor and cross-file substitution still fail.The reviewed lineage from the last accepted
8f9298eb…runner is Nick Petalas's private bytecode caches (9158ee6d), Tekalign's optional finite positive module deadlines (54bbb81c), and Douglas R. Colkitt's descendant cache environment propagation (da400586). The complete successor keeps assertion-enabled children, completion receipts, frozen legacy-family routing, default unlimited module duration and process-group cleanup. This PR does not admit the two intermediate hashes. Credit woklerx and the prior reconciliation contributors for the existing assertion-safety and historical replay adaptations.Canonical base:
20ecf2891d80b5acf18d980b2164fb44ea7faa90, priority revision 6. This is a narrow maintenance repair to offline reconciliation, with no selected-result or frozen-source change. Current open/closed PR and Discussion searches found no equivalent pending successor admission; PR3686 addresses the separate optional-closure failure in the same checker.Test plan
Reproduced the failure on untouched canonical base: four focused controls pass, while the exact-current-successor positive test fails.
CPython 3.12.14 on macOS 27 arm64: all six focused successor tests pass normally and under
-O, with warnings treated as errors.The current runner's actual behavior suites pass normally and under
-O: 10 runner tests, 11 private-bytecode tests and seven deadline tests. One Linux-only process-observation test is skipped on macOS. These run disposable child processes, including timeout and completion-receipt failures.python3.12 -B -m unittest discover -s tests -p test_isolated_test_runner.py -v python3.12 -B -m unittest discover -s tests -p test_isolated_test_bytecode.py -v python3.12 -B -m unittest discover -s tests -p test_isolated_test_deadlines.py -v # Repeated each command with -O -W error.In a disposable copy of exact PR3686 commit
932f3b1ef707733643b5e318c4bf134436ddd766plus only this two-file patch, the entiretest_pr_reconciliation.pymodule passes: 31 tests normally and 31 under-O, both with-W error. PR3686 is not included in this diff.Independent review authenticated all three source commits, checked the unchanged predecessor and runner, and passed the six positive/mutation tests under optimized Python.
git diff --checkpasses.This is not a full historical-ledger or hosted-CI success claim. The separate 24 optional-closure failures are addressed by PR3686; the canonical PR3107 starting-head mismatch and the documentation admission addressed by PR3648 remain separate. No heavy historical replay was repeated for this exact-hash repair.
Hosted follow-up reviewed on 2026-10-19 (JST): the fork push run passes the tooling-exact checks, then stops at the unchanged
docs/ci-verification.mdadmission guard addressed by PR3648. It does not reach the new reconciliation tests; the scoped results above remain local evidence. Upstream Actions are awaiting maintainer approval.Prepared with substantial OpenAI Codex assistance for investigation, implementation, regression controls, execution, independent agent review and writing. Apache-2.0.
Local integration follow-up (2026-10-19 JST): PR3692 repairs the initial-head mismatch using authenticated existing receipts. A disposable canonical-base tree combining its
af040ab4change with exact PR3648a0d88d68, PR3686932f3b1(checker and tests), and PR36883463ba61passes all 38 reconciliation tests normally and under-O, both with-W error, on macOS arm64 / CPython 3.12.14. One 600-second-cappedtooling-ledgerreplay passed the repaired boundaries and batch1047, then stopped after 29.76 seconds at the separate canonical PR1048 detailed-review/evidence mismatch against historical batch1099. The untouched canonical checker independently reproduces that mismatch. Ledger, intake and frozen evidence remain unchanged; full ledger/CI success is still not claimed.