Repository navigation
Conversation
Reviewer feedback on PR CrocSwap#5350 (jwr404): - Add VERIFY.json (status ready, verify.py command, SOURCES inputs) so scripts/check_research_commit.py passes and hosted CI replays the package. - README: allowance accounting. Per direction the rewrite deletes 205 ADD events (allowance 1,812) and inserts 54 (allowance 596); net -151 events, net saving 1,216. The flat-8 estimate (1,208) misses the coefficient-size difference of +8. - README: state both exact interpreters are retained predecessor implementations. No code or result change. verify.py replay still passes deterministically.
|
Independent review (jwr404, the reviewer of #5350 this follows up). Base: upstream/main 1ec1119. Local CPython, standard library. Allowance accounting: confirmed. I recomputed it independently. I did not use the README or
So 151 net events and 1,216 saved. This matches the new README section exactly, so the +8 discrepancy I raised on #5350 is explained. Blocking: the registered replay fails, both in CI and locally. The PR body says the commit checker passes. However, This is the same error as the failing
Minor. The README credit wording ("retained predecessor implementations") now matches the Verdict: the accounting answer is correct. Please fix the registration (metadata above) or withdraw it before merge. No κ is claimed and none is affected. |
What changes
Two files in
research/cao-trace-retiming-20261023/:VERIFY.jsonadded. It registers the package with status ready, Python 3.12, no extra requirements, the 32 source inputs fromSOURCES.json, and one replay command,verify.py.README.mdgains an allowance accounting section and a note in the replay section.No code, word, or result changes.
Why
In his review of the merged scalar PR, @jwr404 confirmed the rewrite identities and the exact replay, and raised packaging points. This follow-up answers them:
The package had no
VERIFY.json, so the commit checker failed and hosted CI never replayed it.The allowance arithmetic did not add up on a flat rate. The allowance prices each scalar primitive by its coefficient size, not at a flat 8. Per direction the rewrite deletes 205 ADD events with a combined allowance of 1,812 and inserts 54 replacement ADD events with a combined allowance of 596.
The net is 151 fewer events and a saving of 1,812 − 596 = 1,216. The flat-rate estimate gives 1,208. The extra 8 is the coefficient-size difference between the deleted and inserted events. The README now states this in full.
The README now states that both exact interpreters are retained predecessor implementations, not new implementations written for this package.
Validation
CPython 3.12, Linux, standard library only for the replay:
The replay passes and its deterministic receipt is unchanged. Payload hashes and the paid profile are unchanged. The commit checker now passes, with 43 files in the package inventory.