Repository navigation
Reuse replay planner input validation within each invocation - #6087
Merged
Mister-Meeseeks merged 2 commits intoOct 28, 2026
Merged
Conversation
Contributor
Author
|
CI follow-up for The plan failure reproduces on clean canonical main |
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replay planner repeatedly validates identical declared input paths across thousands of packages. Reuse successful validation only within one
plan_detailsinvocation; keep every manifest read/hash, exact HEAD and changed-path check, consumer and selection cause. The production change is five added lines.On the pinned 3,678-package checkout, the existing complete-plan benchmark reports a local shared-runner planning median of 1.203 s → 0.640 s (1.88x). All 40 before/after complete plan results match. These are warm, in-process macOS measurements on a busy host; raw samples and source hashes are retained, with no cold-cache or whole-CI speedup claim.
Validation:
The cache is scoped to the existing stable-checkout contract and retains O(U) distinct input names until the call ends; peak memory was not measured. Native Windows execution and hosted CI remain unrun. Since this touches the shared runner, the existing CI planner will select all registered packages. Package export/source-history hooks do not apply to this shared-code change.
Claim: #6077
Credit Douglas Colkitt for the runner, Ali Romman for the reused benchmark, and the retained path/sparse-input guard contributors. Prepared by JoyboyBrian with substantial OpenAI Codex assistance; Apache-2.0. No independent human review is claimed.