Repository navigation
fix(pgadmin): bundle webpack assets for the 9.19 pip wheel - #4597
Merged
ValClarkson merged 1 commit intoNov 19, 2026
Merged
Conversation
The 9.19 wheel omits static/js/generated, so the login page 200s and the UI spins. Rebuild that tree from the matching source tarball, bump the image to 9.19, and pin cryptography>=50.0.0 for CVE-2026-69247.
crunchyheath
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
static/js/generated/tree, so/loginreturns 200 and the UI spinner never stops.image-pgadminoverlay: webpack-bundle the matching source tarball in a throwaway Node stage, copy it into site-packages, and fail the build ifpgadmin_commons.js/vendor.react.js/style.cssare missing.PGADMIN4_VERSION9.17 → 9.19 and pincryptography>=50.0.0(CVE-2026-69247), matching the GitLab image repo.REL_5_8has nocomponents/image-pgadmin; 5.8 still consumes images from GitLabcontainers/build/image-pgadmin.Test plan
make -C components/image-pgadmin buildproduces an image whose/static/js/generated/pgadmin_commons.jsreturns 200/loginin a browser and confirm the page renders (not an infinite spinner)