Skip to content

fix(pgadmin): bundle webpack assets for the 9.19 pip wheel - #4597

Merged
ValClarkson merged 1 commit into
CrunchyData:mainfrom
ValClarkson:fix/pgadmin-9.19-generated-ui
Nov 19, 2026
Merged

ValClarkson merged 1 commit into
CrunchyData:mainfrom
ValClarkson:fix/pgadmin-9.19-generated-ui

Conversation

@ValClarkson

@ValClarkson ValClarkson commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The pgAdmin 9.19 pip wheel ships with an empty static/js/generated/ tree, so /login returns 200 and the UI spinner never stops.
  • Port the GitLab image-pgadmin overlay: webpack-bundle the matching source tarball in a throwaway Node stage, copy it into site-packages, and fail the build if pgadmin_commons.js / vendor.react.js / style.css are missing.
  • Bump PGADMIN4_VERSION 9.17 → 9.19 and pin cryptography>=50.0.0 (CVE-2026-69247), matching the GitLab image repo.

REL_5_8 has no components/image-pgadmin; 5.8 still consumes images from GitLab containers/build/image-pgadmin.

Test plan

  • make -C components/image-pgadmin build produces an image whose /static/js/generated/pgadmin_commons.js returns 200
  • Open /login in a browser and confirm the page renders (not an infinite spinner)
  • Login still works after the cryptography pin

The 9.19 wheel omits static/js/generated, so the login page 200s and the
UI spins. Rebuild that tree from the matching source tarball, bump the
image to 9.19, and pin cryptography>=50.0.0 for CVE-2026-69247.
@ValClarkson
ValClarkson merged commit 0478c1d into CrunchyData:main Nov 19, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants