feat(config): a suggestions option that stops backend generation - #20
Open
Antisophy wants to merge 1 commit into
Open
feat(config): a suggestions option that stops backend generation#20Antisophy wants to merge 1 commit into
Antisophy wants to merge 1 commit into
Conversation
Next-message suggestions cost a small-model one-shot at every turn end and on opening a live task, whether or not anyone reads them. A top-level `suggestions: false` now stops the backend from creating them at all, gated inside generateSuggestions so every trigger site goes quiet with one check; the suggestion bar simply never populates. The option is deliberately not under gui:, since it stops the work, not the display. Title generation is separate and unaffected: new tasks still get auto-titles. Default unchanged (enabled). The spec drives two full turns with suggestions disabled and asserts the bar stays empty; the second turn bounds the wait without a wall-clock sleep, since the generation one-shot answers from the same mock the turns do.
CyberShadow
reviewed
Aug 29, 2026
CyberShadow
left a comment
CyberShadow
left a comment
Owner
There was a problem hiding this comment.
No objections to the idea - just implementation nits.
| /// Generate next-message suggestions (a small-model one-shot at each turn | ||
| /// end and on opening a live task). Set false to stop the backend from | ||
| /// creating them at all; title generation is separate and unaffected. | ||
| @Optional SetInfo!bool suggestions; |
Owner
There was a problem hiding this comment.
I think we can just do @Optional bool suggestions = true; ?
|
|
||
| void generateSuggestions(int tid) | ||
| { | ||
| if (host_.suggestionsEnabled !is null && !host_.suggestionsEnabled()) |
Owner
There was a problem hiding this comment.
Unnecessarily defensive - will never be null?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next-message suggestions cost a small-model one-shot at every turn end and on opening a live task, whether or not anyone reads them. A top-level
suggestions: falsenow stops the backend from creating them at all, gated inside generateSuggestions so every trigger site goes quiet with one check; the suggestion bar simply never populates. The option is deliberately not under gui:, since it stops the work, not the display. Title generation is separate and unaffected: new tasks still get auto-titles. Default unchanged (enabled).The spec drives two full turns with suggestions disabled and asserts the bar stays empty; the second turn bounds the wait without a wall-clock sleep, since the generation one-shot answers from the same mock the turns do.