Repository navigation
feat: classes for optional features can indicate wehether they cannot act - #1534
Open
jkowalleck wants to merge 14 commits into
Open
jkowalleck wants to merge 14 commits into
jkowalleck wants to merge 14 commits into
Conversation
… act Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Not up to standards ⛔🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | -2 |
🔴 Coverage 73.86% diff coverage · -0.35% coverage variation
Metric Results Coverage variation ✅ -0.35% coverage variation (-1.00%) Diff coverage ❌ 73.86% diff coverage (90.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (1f6699e) 26583 26184 98.50% Head commit (617a99f) 26928 (+345) 26430 (+246) 98.15% (-0.35%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#1534) 153 113 73.86% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Documentation build overview
5 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
cannotpropertyIt tells whether missing optional dependencies prevent the class from acting:
falsewhen the feature is available;otherwise an object with a
messagedescribing why the feature is unavailable.Affected classes:
Serialize.JsonSerializer— alwaysfalseSerialize.XmlSerializer— alwaysfalsein web builds; in node it depends on an optional XML libraryValidation.JsonValidatorValidation.JsonStrictValidatorValidation.XmlValidatorChanged
Serialize.XmlSerializer,Validation.JsonValidator,Validation.JsonStrictValidatorandValidation.XmlValidatornow throw
MissingOptionalDependencyErrorbased on the newcannotcheck,instead of wrapping the underlying
OptPlugError