Retain all saved image rotations in GalleryThumbnails - #919
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pull request overview
This PR fixes a state-sync issue in the camera gallery flow where GalleryThumbnails could lose later rotations when multiple images are rotated and saved during the same full-screen preview session. The fix ensures the bottom sheet returns its current (authoritative) image list on each save, so subsequent edits build on the latest state.
Changes:
- Update the gallery bottom sheet callback to pass the current image collection back to
GalleryThumbnailson each saved rotation. - Add a unit test covering sequential edits within a single open gallery session.
- Document the expected post-capture review/rotation behavior in the wiki.
📁 File summary (5 files changed)
| File | Description |
|---|---|
src/library/DIPS.Mobile.UI/API/Camera/Gallery/GalleryThumbnails.cs |
Accept updated image list from the bottom sheet and rebind using a fresh list copy. |
src/library/DIPS.Mobile.UI/API/Camera/Gallery/BottomSheet/GalleryBottomSheet.cs |
Change update callback to supply the current Images collection on save. |
src/tests/unittests/API/Camera/Gallery/GalleryThumbnailsTests.cs |
Regression test for multiple sequential edits in one open gallery. |
wiki/Media/ImageCapture.md |
Document post-capture review behavior and rotation retention expectations. |
CHANGELOG.md |
Add patch note describing the rotation retention fix. |
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Adds a patch entry documenting the fix. |
| src/library/DIPS.Mobile.UI/API/Camera/Gallery/BottomSheet/GalleryBottomSheet.cs | Passes the bottom sheet’s current image list back on save to avoid stale state. |
| src/library/DIPS.Mobile.UI/API/Camera/Gallery/GalleryThumbnails.cs | Updates UpdateImages to accept the authoritative image list and rebind. |
| src/tests/unittests/API/Camera/Gallery/GalleryThumbnailsTests.cs | Adds regression coverage for sequential rotations in a single session. |
| wiki/Media/ImageCapture.md | Documents expected review/rotation behavior after capture. |
eirinsvi
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes
GalleryThumbnailslosing later image rotations when several images are edited during the same full-screen preview session.Todos