Fixing build-time problem in dependents - #16
manchicken wants to merge 3 commits into
Conversation
|
Heya @manchicken , thank you so much for taking the time to open a MR. Would you mind to explain where this issue occurs? I am a little confused as no other test files are referenced in the Happy to merge these changes as is, just trying to better understand. |
|
When I added this module to my Zig project, builds failed because the fixtures couldn't be generated because the folder was missing. This should be the change to that file, but also the addition of a |
|
Let me look into that... |
|
The replacing MR should contain a better approach imo. What's your take? |
|
I don't mind that approach at all, but does it still depend on the folder being there? |
|
Nope, as the relevant code that caused the error was removed. Therefore, making your changes redundant. I added you as a coauthor should that be of relevance to you. |
|
Fixtures used to be dynamically added at build time which caused the error when the relevant path wasn't found. Now, we just embed the fixtures explicitly at compile time. I figured I was being smart with my initial approach, but explicit |
|
Marvelous! Thank you so much! |
|
Closing due to merge of #18 |
|
Thank you again, @manchicken ! |
The fixtures generated by the
build.zigare unable to succeed because the test/fixtures tree is missing. Added a.diremptyfile and an entry inbuild.zig.zonto keep it.Let me know if there's a better way to solve this, but this did seem like the simplest path to fixing the build issue.