Skip to content

Fixing build-time problem in dependents - #16

Closed
manchicken wants to merge 3 commits into
DISTREAT:masterfrom
manchicken:master
Closed

manchicken wants to merge 3 commits into
DISTREAT:masterfrom
manchicken:master

Conversation

@manchicken

Copy link
Copy Markdown
Contributor

The fixtures generated by the build.zig are unable to succeed because the test/fixtures tree is missing. Added a .dirempty file and an entry in build.zig.zon to keep it.

Let me know if there's a better way to solve this, but this did seem like the simplest path to fixing the build issue.

@DISTREAT

Copy link
Copy Markdown
Owner

Heya @manchicken , thank you so much for taking the time to open a MR.

Would you mind to explain where this issue occurs? I am a little confused as no other test files are referenced in the build.zig.zon.

Happy to merge these changes as is, just trying to better understand.

@manchicken

Copy link
Copy Markdown
Contributor Author

When I added this module to my Zig project, builds failed because the fixtures couldn't be generated because the folder was missing. This should be the change to that file, but also the addition of a .dirempty file to preserve the folder.

@DISTREAT

Copy link
Copy Markdown
Owner

Let me look into that...

@DISTREAT

Copy link
Copy Markdown
Owner

The replacing MR should contain a better approach imo. What's your take?

@manchicken

Copy link
Copy Markdown
Contributor Author

I don't mind that approach at all, but does it still depend on the folder being there?

@DISTREAT

Copy link
Copy Markdown
Owner

Nope, as the relevant code that caused the error was removed. Therefore, making your changes redundant.

I added you as a coauthor should that be of relevance to you.

@DISTREAT

DISTREAT commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Fixtures used to be dynamically added at build time which caused the error when the relevant path wasn't found.

Now, we just embed the fixtures explicitly at compile time.

I figured I was being smart with my initial approach, but explicit @embedFiles replace the janky build logic and reduce the code base.

@manchicken

Copy link
Copy Markdown
Contributor Author

Marvelous! Thank you so much!

@DISTREAT

Copy link
Copy Markdown
Owner

Closing due to merge of #18

@DISTREAT DISTREAT closed this Sep 23, 2026
@DISTREAT

Copy link
Copy Markdown
Owner

Thank you again, @manchicken !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants