Skip NADP live-API tests (module deprecated)#259
Merged
thodson-usgs merged 1 commit intoDOI-USGS:mainfrom May 4, 2026
Merged
Conversation
The NADP module is deprecated and scheduled for removal on 2026-11-01 (see DOI-USGS#243). Both tests in this file hit the live NADP services and have been intermittently exhausting CI retries. Skip them via `pytestmark` rather than deleting, so the test bodies remain available if needed during the deprecation window. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/nadp_test.pyhit the live NADP services and have been intermittently exhausting CI retries.pytestmark = pytest.mark.skip(...)so they're disabled but the bodies stay around during the deprecation window. Once the module is removed the test file can go with it.Test plan
pytest tests/nadp_test.pyreports2 skipped.🤖 Generated with Claude Code