Repository navigation
fix(importer): unbreak @repo/crawlers build and make it consumable from Rate-Services - #105
Merged
Merged
Conversation
…ixes #103) - FlagshipDeviceSeed: make expert_review_summary / expert_criteria_scores optional. The 8 seeds added in 310ef3d have no expert write-up and broke `pnpm --filter @repo/crawlers build` (TS2739), turning dev CI red. The matching master_products columns are nullable. - tsconfig: rootDir ./src + declaration, so dist/index.js actually exists (main pointed at a file that was emitted as dist/src/index.js) and consumers get .d.ts types. - package.json: add types and exports ("." and "./shopee/*") so DOS/Rate-Services can import the engine instead of keeping copies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8kEoAgmss5ZwS8ziunTj
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The wildcard also exposed test-ai-enricher, test-review-analyzer and run-ingestion-test, which execute on import. Only export the two library modules Rate-Services needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8kEoAgmss5ZwS8ziunTj
JOY (JOY)
pushed a commit
that referenced
this pull request
Oct 16, 2026
…vices Follow-up to #105 / DOS/Rate-Services#15, which made Rate-Services consume the engine through the vendor/rate submodule. - Add `test:dist`, a smoke test that imports @repo/crawlers (root, ./shopee/arena-spec-syncer, ./shopee/flagship-seed-data) and @repo/shared-data by package name from the built dist, checks the .d.ts files, and asserts that the test scripts that execute on import stay unexported. Run it in CI after the crawler tests. - AGENTS.md / CLAUDE.md: document that Rate-Services consumes the engine via the submodule and must not copy engine files, and replace the stale `npm run build` Rate-Services commands with the pnpm ones. - ROADMAP: record the change as 5.19. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015v1boe4iagzc2mQVMuU39b
5 of 6 tasks
JOY (JOY)
pushed a commit
that referenced
this pull request
Oct 16, 2026
Cover the .d.ts behind the ./shopee/flagship-seed-data export, and credit #105 / #107 separately in ROADMAP 5.19 (review follow-up). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015v1boe4iagzc2mQVMuU39b
JOY (JOY)
added a commit
that referenced
this pull request
Oct 16, 2026
…vices (#107) - Add `test:dist`, a smoke test that imports @repo/crawlers (root, ./shopee/arena-spec-syncer, ./shopee/flagship-seed-data) and @repo/shared-data by package name from the built dist, checks the .d.ts files, and asserts that the test scripts that execute on import stay unexported. Run it in CI after the crawler tests. - AGENTS.md / CLAUDE.md: document that Rate-Services consumes the engine via the vendor/rate submodule and must not copy engine files; replace the stale `npm run build` Rate-Services commands with the pnpm ones. - ROADMAP: record the change as 5.19. Follow-up to #103 / #105 and DOS/Rate-Services#15. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015v1boe4iagzc2mQVMuU39b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlagshipDeviceSeed:expert_review_summary/expert_criteria_scoresare now optional.apps/importer/tsconfig.json:rootDir: ./src+declaration: true.apps/importer/package.json:types+exportsfor.,./shopee/arena-spec-syncerand./shopee/flagship-seed-data. The subpaths are explicit on purpose: a./shopee/*wildcard would also exposetest-ai-enricher,test-review-analyzerandrun-ingestion-test, which execute on import.devCI has been red since 310ef3d ([Phase 5.10] 2026 Multi-Category Flagship Lineup (iPad Pro M5, Xiaomi Pad 7 Pro, MacBook M4, Watch S11/Ultra 3, AirPods Pro 3, WF-1000XM6) & ProductNormalizer Rules #59): the 8 new 2026 seeds have no expert write-up, sopnpm --filter @repo/crawlers buildfails with TS2739 on every push. The matchingmaster_productscolumns are nullable (TEXT,JSONB DEFAULT '{}'), and supabase-js dropsundefinedkeys, so the backfill leaves them unset instead of inventing review text.mainpointed atdist/index.js, but withrootDir: "."tsc emitteddist/src/index.js, and no.d.tsfiles were produced. That made@repo/crawlersimpossible to consume as a package, which is why DOS/Rate-Services ended up hand-copying the engine (see refactor(importer): make @repo/crawlers the single source of truth for Rate-Services #103). The copies carry no logic of their own: after prettier they are identical to, or strict subsets of, the files here.Fixes #103
Checklist
@repo/shared-data,@repo/crawlers,@repo/extension,@repo/web(Next.js 16)pnpm --filter @repo/web typecheck@repo/crawlers test,@repo/extension test,@repo/web test@repo/crawlersas a package before; smoke-tested the three export paths, and confirmed@repo/crawlers/shopee/test-ai-enricheris blocked withERR_PACKAGE_PATH_NOT_EXPORTED)Notes
apps/importeronlyDOS/Ratesubmodule and delete its copies (DOS/Rate-Services#14).🤖 Generated with Claude Code
https://claude.ai/code/session_01SJ8kEoAgmss5ZwS8ziunTj