No max-height on thumbnails allows oversized images to break layout

[MMilosz]

Describe the bug

There is no max-height constraint on thumbnails, so an extremely tall image can break the layout. Observed on sandbox.dspace.org in both Chrome v154.0 and Firefox v156.0

Below, a very tall blue-red gradient is served as a thumbnail:

To Reproduce

Prepare a large image. If you have ImageMagick available via CLI, you can do so by running:

$ magick -size 250x1000 gradient:blue-red gradient.png

Select any item. Go to Edit -> Bitstreams tab -> press Upload -> select the THUMBNAIL bundle and upload the image. Save and view the item page. Observe the thumbnail overflows

Expected behavior

Thumbnails should have a max-height constraint so oversized images don't break the layout

Related work

• Add max-height constraint to thumbnails (+ upscale small images) #6265

[lgeggleston]

Hi @MMilosz, thanks for noting and submitting a fix!

As Alan noted, this is an adjacent (though different) issue to DSpace/DSpace#12004 and the frontend PR for that is also adjusting size styling on thumbnails, so this will just require checking whether there are conflicts between those changes or they can layer.