Fix scripts dropdown not loading new elements while being zoomed in or out

[AndreaBarbasso]

References

• Fixes The "New process" dropdown might not load more than one page if the browser zoom is not 100%. #4577

Description

Added a small offset in order to fix issues regarding floating-point multiplications with non-integer pixel values, caused by the browser being zoomed in or out.

Instructions for Reviewers

List of changes in this PR:

• Added a small offset to avoid issues with non-integer values not being calculated correctly;
• Added tests.

The issue can be reproduced thanks to the instructions found on #4577.

scroll.processes.mp4

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[lgeggleston]

✅ Tested and this looks good! Note: not a full code review.
Tried with positive and negative zoom on Chrome, Firefox and Safari, with elementsPerPage set to 10; full list of processes always loaded on scroll.

It does look like the tests on 22.0 were paused though, so you may need to re-trigger the tests to complete.

[tdonohue]

Temporarily closing & reopening to trigger tests to rerun (since the Node 22 test has failed to trigger)

[tdonohue]

👍 Thanks @AndreaBarbasso ! Code looks good to me & I trust the testing from @lgeggleston .

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] Fix scripts dropdown not loading new elements while being zoomed in or out #5624

[dspace-bot]

Successfully created backport PR for dspace-8_x:

• [Port dspace-8_x] Fix scripts dropdown not loading new elements while being zoomed in or out #5625

[dspace-bot]

Successfully created backport PR for dspace-9_x:

• [Port dspace-9_x] Fix scripts dropdown not loading new elements while being zoomed in or out #5626