fix #5525: add independent scroll to filters bar#5556
Conversation
|
I have tested, the independent scrollbar appeared which scrolls only the sidebar facets. In my test I could only get to the bottom facets if I am using just a little bit the search result scrolling pane. pr_5556.mp4 |
nathanmlf
left a comment
There was a problem hiding this comment.
Unlike the issue mentioned by @kanasznagyzoltan, I am able to scroll all the way down to the bottom facets within the sidebar without needing to scroll the main page first. For context, I tested this on Windows 10 using Google Chrome at 1920x1080.
Approving the PR as it works fine in my environment, but it might be worth double-checking how it behaves on others viewports. Great addition, @guillermo-escire!
|
@nathanmlf pr_5556_2.mp4 |
|
@kanasznagyzoltan pr_5556_test2.mp4Also, I'am using the sandbox backend and someone happened to be testing a banner right above the header. This reinforces what you said in your first comment, the sidebar scrollbar only works perfectly when we scroll down the main page. pr_5556_test3.mp4 |
nathanmlf
left a comment
There was a problem hiding this comment.
Hello @guillermo-escire!
I’ve been testing the new implementation localy and I can confirm the behavior mentioned by @kanasznagyzoltan . On my end, I noticed that the "Reset Filters" button is currently hidden and only becomes accessible after scrolling down the main page. I am using a 1920x1080 monitor with an upscale of 125%.
I’m marking this as "Request Changes" just so we can discuss if this is the intended behavior. Also, while testing using the sandbox backend there was a banner above the header, and it seems to interfere with how the filter height is calculated. It looks like the max-height might need a more dynamic approach to account for different header sizes or page offsets.
I’ve attached two videos in my last comment to show exactly what’s happening on my end. Thanks for the contribution, I will be happy to re-test it if needed!
References
Fixes #5525
Description
The filters bar was causing the whole page to scroll when interacting
with it. Added independent scroll behavior to the filters sidebar so
it scrolls on its own without moving the entire page.
Instructions for Reviewers
List of changes in this PR:
overflow-y: autoto the:hostselector in search-filters.component.scss to enable independent scrollingoverscroll-behavior: containto prevent scroll events from propagating to the parent pageTo test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.