Skip to content

Fix search facets slide animation in safari#5637

Open
artlowel wants to merge 1 commit intoDSpace:mainfrom
atmire:fix-safari-animations-10.0.0-next
Open

Fix search facets slide animation in safari#5637
artlowel wants to merge 1 commit intoDSpace:mainfrom
atmire:fix-safari-animations-10.0.0-next

Conversation

@artlowel
Copy link
Copy Markdown
Member

@artlowel artlowel commented May 8, 2026

References

Description

This gives <ds-search-facet-filter-wrapper> display:block so angular can calculate its height in safari, to make the slide animation work.

Instructions for Reviewers

Verify that the facets on the search page slide open properly in safari now, and that they still work as before in other browsers

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

@artlowel artlowel self-assigned this May 8, 2026
@artlowel artlowel added the bug label May 8, 2026
@artlowel artlowel added component: Discovery related to discovery search or browse system high priority ux User Experience related works testathon Reported by a tester during Community Testathon port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release affects: 9.x Issue impacts 9.x releases labels May 8, 2026
@artlowel artlowel moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 8, 2026
@artlowel artlowel removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 8, 2026
@artlowel
Copy link
Copy Markdown
Member Author

artlowel commented May 8, 2026

@tdonohue I noticed it didn't cherry-pick clean to 7.x, but it does to 8.x and 9.x, so I created #5638 already. The 8 and 9 backports should work automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases affects: 9.x Issue impacts 9.x releases bug component: Discovery related to discovery search or browse system high priority port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release testathon Reported by a tester during Community Testathon ux User Experience related works

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Filter facet values overlap other filters in results list and become unusable on Safari

1 participant