Skip to content

Prevent server-side rendering of language switch #6272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschaszott wants to merge 2 commits into
base: main
Choose a base branch
from
+34 −27
Open

Prevent server-side rendering of language switch #6272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab0e3e0
adjust lang-switch component tests to handle deferred rendering
saschaszott Sep 27, 2026
d1221dc
do not include language switch component in SSR result
saschaszott Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 29 additions & 26 deletions src/app/shared/lang-switch/lang-switch.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,32 @@
@if (moreThanOneLanguage) {
<div ngbDropdown class="navbar-nav" display="dynamic" placement="bottom-right">
<button role="button"
[attr.aria-label]="'nav.language' |translate"
aria-controls="language-menu-list"
aria-haspopup="menu"
class="dropdown-toggle btn btn-link px-0"
[title]="'nav.language' | translate"
(click)="$event.preventDefault()" data-bs-toggle="dropdown" ngbDropdownToggle
data-test="lang-switch"
tabindex="0">
<i class="fas fa-globe-asia fa-lg fa-fw"></i>
</button>
<div ngbDropdownMenu class="dropdown-menu" [attr.aria-label]="'nav.language' |translate" id="language-menu-list"
role="listbox">
@for (lang of translate.getLangs(); track lang) {
<div class="dropdown-item" tabindex="0"
role="option"
[lang]="lang"
(keyup.enter)="useLang(lang)"
(click)="useLang(lang)"
[attr.aria-selected]="lang === translate.getCurrentLang()"
[class.active]="lang === translate.getCurrentLang()">
{{ langLabel(lang) }}
</div>
}
<!-- Not rendered during SSR: the switch is only useful to interactive human users -->
@defer {
<div ngbDropdown class="navbar-nav" display="dynamic" placement="bottom-right">
<button role="button"
[attr.aria-label]="'nav.language' |translate"
aria-controls="language-menu-list"
aria-haspopup="menu"
class="dropdown-toggle btn btn-link px-0"
[title]="'nav.language' | translate"
(click)="$event.preventDefault()" data-bs-toggle="dropdown" ngbDropdownToggle
data-test="lang-switch"
tabindex="0">
<i class="fas fa-globe-asia fa-lg fa-fw"></i>
</button>
<div ngbDropdownMenu class="dropdown-menu" [attr.aria-label]="'nav.language' |translate" id="language-menu-list"
role="listbox">
@for (lang of translate.getLangs(); track lang) {
<div class="dropdown-item" tabindex="0"
role="option"
[lang]="lang"
(keyup.enter)="useLang(lang)"
(click)="useLang(lang)"
[attr.aria-selected]="lang === translate.getCurrentLang()"
[class.active]="lang === translate.getCurrentLang()">
{{ langLabel(lang) }}
</div>
}
</div>
</div>
</div>
}
}
6 changes: 5 additions & 1 deletion src/app/shared/lang-switch/lang-switch.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
} from '@angular/core';
import {
ComponentFixture,
DeferBlockState,
TestBed,
waitForAsync,
} from '@angular/core/testing';
Expand Down Expand Up @@ -91,7 +92,7 @@ describe('LangSwitchComponent', () => {
provideHttpClientTesting(),
],
}).compileComponents()
.then(() => {
.then(async () => {
translate = TestBed.inject(TranslateService);
translate.addLangs(mockConfig.languages.filter((langConfig: LangConfig) => langConfig.active === true).map((a) => a.code));
translate.setFallbackLang('en');
Expand All @@ -103,6 +104,9 @@ describe('LangSwitchComponent', () => {
de = fixture.debugElement;
langSwitchElement = de.nativeElement;
fixture.detectChanges();
// The language dropdown is wrapped in a @defer block (not rendered during SSR), so we need to render it explicitly
const deferBlock = await fixture.getDeferBlocks();
await deferBlock[0].render(DeferBlockState.Complete);
});
}));

Expand Down
Loading