Repository navigation
Conversation
…#2231) The DateOnly/TimeOnly re-enable (6d48ef6) added a TypeCode.Object guard that blocks legitimate direct unboxes where both sides report Object but the runtime type satisfies the target — e.g. short[] to IReadOnlyList<short>. Adds unboxType.IsAssignableFrom(colType) as a direct-unbox trigger. IReadOnlyList<short>.IsAssignableFrom(short[]) is true (fix works), while TimeOnly.IsAssignableFrom(TimeSpan) is false (the original DateOnly/TimeOnly fix stays intact).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2231.
The DateOnly/TimeOnly re-enable (6d48ef6, #2228) added a TypeCode.Object guard to the direct-unbox condition in LoadReaderValueOrBranchToDBNullLabel. That guard also blocks legitimate direct unboxes where both sides report TypeCode.Object but the runtime type satisfies the target — e.g. Npgsql returns SMALLINT[] as short[], and mapping it to IReadOnlyList fell through to Convert.ChangeType, which throws InvalidCastException on arrays.
This adds unboxType.IsAssignableFrom(colType) as a direct-unbox trigger:
The check runs once per column at deserializer-build time (cached), so there's no per-row perf cost.