Skip to content

ci: read node version from .nvmrc in github workflows (#4919) #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NoopDog wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: read node version from .nvmrc in github workflows (#4919) #4921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ae69e7
ci: read node version from .nvmrc in github workflows (#4919)
NoopDog Aug 11, 2026
5355d8d
ci: cache npm, align deploy scripts and docs with .nvmrc (#4919)
NoopDog Aug 11, 2026
d470c30
ci: quote .nvmrc read in deploy scripts, add set -e to dev deploy (#4…
NoopDog Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/run-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ jobs:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.12.0"
node-version-file: ".nvmrc"
cache: "npm"
cache-dependency-path: |
package-lock.json
files/package-lock.json
- run: |
npm ci
npm run check-format
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/run-playwright-tests-anvil-catalog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ jobs:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.12.0"
node-version-file: ".nvmrc"
cache: "npm"
cache-dependency-path: |
package-lock.json
files/package-lock.json
- name: Install dependencies
run: |
npm ci
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/run-playwright-tests-anvil-cmg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ jobs:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: "22.12.0"
node-version-file: ".nvmrc"
cache: "npm"
cache-dependency-path: "package-lock.json"
- name: Install dependencies
run: |
npm ci
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The HCA Data Browser is built using [Next.js](https://nextjs.org/).

## Prerequisites

Node.js 22.12.0 is required to run the app.
Node.js 22.13.0 (see `.nvmrc`) is required to run the app.

### 1. Clone the Repo

Expand Down
4 changes: 3 additions & 1 deletion cc-anvil-catalog-dev-deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
#!/usr/bin/env bash
# Set the script to exit immediately on error
set -e

echo \"Deleting ./out/\"
rm -rf ./out

echo \"Deleting ./build/\"
rm -rf ./build

n 22.12.0
n "$(cat .nvmrc)"
npm ci
export NEXT_PUBLIC_BASE_PATH="/data"

Expand Down
2 changes: 1 addition & 1 deletion cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -e
echo \"Deleting ./out/\"
rm -rf ./out

n 22.12.0
n "$(cat .nvmrc)"
npm ci

# Build
Expand Down
2 changes: 1 addition & 1 deletion cc-explore.anvilproject.dev.clevercanary.com-deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ rm -rf ./out
echo \"Deleting ./build/\"
rm -rf ./build

n 22.12.0
n "$(cat .nvmrc)"
npm ci

mkdir -p build/explore/anvil-cmg
Expand Down
2 changes: 1 addition & 1 deletion cgl-anvil-catalog-prod-deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ rm -rf ./out
echo \"Deleting ./build/\"
rm -rf ./build

n 22.12.0
n "$(cat .nvmrc)"
npm ci
export NEXT_PUBLIC_BASE_PATH="/data"

Expand Down
Loading