Repository navigation
Conversation
mcculls
requested review from
AlexeyKuznetsov-DD
and removed request for
a team
October 17, 2026 19:01
mcculls
force-pushed
the
mcculls/loader-value-and-filter-tests
branch
from
October 17, 2026 19:01
b7898c3 to
636fca5
Compare
AlexeyKuznetsov-DD
approved these changes
Oct 17, 2026
AlexeyKuznetsov-DD
left a comment
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM. Left two very minor, optional comments about TableTest usage.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds ClassLoaderValue contention tests that force competing boot- and system-loader computations and verify every caller receives the installed value. Extends ClassNameFilter collision tests to cover differing simple-name lengths and last characters, and verifies invalid file magic is rejected.
Motivation
The loader-value tests previously left both CAS failure paths unexercised. Filter tests covered first-character hash collisions but left length and last-character mismatches, along with invalid serialized input, uncovered.
Additional Notes
Validation: all 87 utils tests pass on Java 8, 11, 17, 21, and 25, together with Spotless, SpotBugs, and coverage generation.
git diff --checkpasses. Coverage confirms both outcomes of each loader CAS branch are exercised and ClassNameFilter reaches 100% line and branch coverage.