Repository navigation
Conversation
Cover class, field, method, type, access, and name matchers, including signature overloads, annotations, composition, short-circuiting, and descriptor views. Share outline and ASM fixtures to keep tests concise. Compare generated signatures against reflection, exercise modified UTF-8 and malformed input, and check annotation registration in fresh JVMs and concurrent workers. Cover byte-key collisions and nested matcher unions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fix exact method return-type matching and expand class-match test coverage. Both
returning(String)andreturning(Class<?>)now include the closing parameter delimiter when matching a return descriptor, so a request forintno longer matchesint[], and object names cannot match suffixes of other class names.Add tests for class, field, method, type, access, and name matchers; signature overloads; annotations; composition and short-circuiting; and outline descriptor views. Exercise bytecode parsing with generated signatures checked against reflection, modified UTF-8, malformed input, byte-key collisions, and nested matcher unions. Verify annotation registration in fresh JVMs and concurrent workers, using shared outline and ASM fixtures.
Motivation
Protect matcher and parser behavior with broader regression coverage, including false positives in exact return-type matching.
Additional Notes
Validation:
./gradlew :class-match:check --no-configuration-cachepassed using cached/up-to-date results, including tests on Java 8, 11, 17, 21, and 25, Spotless, and SpotBugs.Contributor Checklist