Remove remaining Gradle buildscript blocks#11975
Remove remaining Gradle buildscript blocks#11975gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
Conversation
Load the DataNucleus enhancer from a dedicated project configuration instead of the script classpath. This keeps the enhancer dependencies in the normal dependency model and resolves them only when the enhance task runs. Also, this project already gets repository setup from the shared Java build scripts.
The root build already declares the forbidden-apis plugin version. Reuse that plugin declaration from the shared script instead of carrying a second script-level classpath and repository setup.
bric3
added
tag: no release notes
![datadog-prod-us1-5[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
This PR safely removes two Gradle buildscript blocks by consolidating plugin and dependency resolution into standard Gradle mechanisms (root plugin declaration and lazy configurations). The removed script classpath complexity is replaced with simpler, more maintainable Gradle patterns. No behavioral regressions identified.
🤖 Datadog Autotest · Commit 275ddc0 · What is Autotest? · Any feedback? Reach out in #autotest
|
🎯 Code Coverage (details) 🔗 Commit SHA: 36661df | Docs | Datadog PR Page | Give us feedback! |
sarahchen6
left a comment
sarahchen6
left a comment
There was a problem hiding this comment.
Nice! just curious - how'd you know we can do this?
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
|
/merge -f --reason="Additional JVM and architecture won't change the output" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: Additional JVM and architecture won't change the output |
2 participants
What Does This Do
Removes the two remaining Gradle
buildscriptblocks.DataNucleus now loads its enhancer from a dedicated lazy project configuration instead of the script classpath (which is now usually a bad practice). The shared Java build scripts already configure repositories for normal project dependencies.
The forbidden-apis script now relies on the plugin version declared by the root build instead of carrying its own script classpath and repository setup.
Motivation
This keeps plugin and dependency resolution in the normal Gradle model and removes duplicated repository/classpath configuration from script plugins.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]