Skip to content

Ensure OTLP Traces Endpoint uses OTLP Traces Protocol Config - #12366

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mhlidd/fix_otlp_traces_config
Sep 1, 2026
Merged

Ensure OTLP Traces Endpoint uses OTLP Traces Protocol Config#12366
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mhlidd/fix_otlp_traces_config

Conversation

@mhlidd

@mhlidd mhlidd commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Previously, OTLP Traces Endpoint was fetched based on the protocol set by the OTLP Metrics Protocol config. This PR replaces that w/ the config set by the OTLP Traces Protocol instead.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mhlidd
mhlidd requested a review from a team as a code owner September 1, 2026 19:02
@mhlidd
mhlidd requested review from mcculls and sarahchen6 and removed request for a team September 1, 2026 19:02
@dd-octo-sts

dd-octo-sts Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mhlidd mhlidd added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes inst: opentelemetry OpenTelemetry instrumentation comp: config Configuration labels Sep 1, 2026

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The default OTLP traces endpoint now follows the OTLP traces protocol. This behavior agrees with the related OTLP endpoint selection logic.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 158a24f · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-official

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.72 s 14.58 s [+0.2%; +1.6%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.66 s 13.67 s [-0.8%; +0.7%] (no difference)
startup:petclinic:appsec:Agent 16.61 s 16.77 s [-5.4%; +3.5%] (no difference)
startup:petclinic:iast:Agent 17.00 s 17.00 s [-0.8%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 16.83 s 16.87 s [-1.5%; +1.0%] (no difference)
startup:petclinic:sca:Agent 16.98 s 16.83 s [-0.1%; +1.8%] (no difference)
startup:petclinic:tracing:Agent 15.66 s 16.29 s [-7.9%; +0.2%] (no difference)

Commit: 158a24f2 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mhlidd
mhlidd added this pull request to the merge queue Sep 1, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 1, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-01 20:32:39 UTC ℹ️ Start processing command /merge


2026-09-01 20:32:44 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-01 21:22:12 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 9c0cbfb:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 1, 2026
@mhlidd
mhlidd added this pull request to the merge queue Sep 1, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 1, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-01 21:54:11 UTC ℹ️ Start processing command /merge


2026-09-01 21:54:17 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-01 22:39:41 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 1, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 87ed682 into master Sep 1, 2026
606 of 610 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the mhlidd/fix_otlp_traces_config branch September 1, 2026 22:39
@github-actions github-actions Bot added this to the 1.66.0 milestone Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: config Configuration inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants