ci: gate notify-slo-breaches like check-slo-breaches - #4165
Open
igoragoli wants to merge 1 commit into
Open
Conversation
igoragoli
added
the
AI Generated
The fallthrough rule for notify-slo-breaches carried no `when:`, so the job inherited `when: always` from the template and ran in pipelines where check-slo-breaches itself fell through to `when: manual` and was never triggered. Since the notifier tests for the check-completed marker file rather than an exit code, a check that never ran looks the same as one that failed, and scheduled master pipelines without NIGHTLY_BENCHMARKS alerted "SLO checks failed to complete" with nothing wrong. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
igoragoli
force-pushed
the
augusto/php-notify-slo-match-check-gate
branch
from
September 7, 2026 14:49
23a4644 to
1713f9c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On this pipeline, check-slo-breaches was skipped due to it being a nightly benchmark pipeline, but notify-slo-breaches ran and incorrectly notified a failure.
notify-slo-breaches should not run on nightly benchmarks, and this PR disables it.
when: manualandallow_failure: trueto the fallthrough rule of.notify-slo-breaches-rules, matching.macrobenchmarks-rules.when:, so the job inheritedwhen: alwaysfrom the template and ran even when its sharedif:condition was false.NIGHTLY_BENCHMARKSunset, macrobenchmarks and check-slo-breaches fall through to manual and are never triggered. notify-slo-breaches ran anyway.fail-on-breach.status.check-completedmarker file, so a check that never ran looks the same as one that failed.when: alwaysstill holds on master and release branches, where a check failure means a breach was detected.Nightly pipelines now send no notification, which is intended: there is no check result to report.
Reviewer checklist