-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Product Analytics] Update funnel conversion calculation #39198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhangmatthieu
wants to merge
6
commits into
master
Choose a base branch
from
matthieu.zhang/update-funnel-conversion-model
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−4
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dabdccc
Update funnel conversion calculation
zhangmatthieu c2084f5
Highlight funnel conversion events
zhangmatthieu 6b7fe7c
Fix funnel sequence formatting
zhangmatthieu 55f3a96
Increase funnel conversion emphasis
zhangmatthieu 779f681
Correct funnel conversion sequence
zhangmatthieu d8fae89
Update hugo/content/en/product_analytics/charts/funnel_analysis.md
zhangmatthieu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style: Inline HTML with hard-coded styles (
<strong style="font-weight: 900">) is unusual in this repo's markdown content and can cause styling drift if the site's typography changes. If the goal is just to highlight the matched events within a monospace run, the existing**...**markdown inside a code span may not render bold — but a lightweight alternative would be to wrap the highlighted characters in a semantic class (or use backticks around each matched event) rather than inlinefont-weight: 900. Not a blocker if this is the agreed-upon pattern for this page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be confirmed, not sure what the alternatives are to bold some of the letters