test(rabbitmq): add rabbitmq-full evalya metric-coverage fixture - #25104
Draft
NouemanKHAL wants to merge 1 commit into
Draft
test(rabbitmq): add rabbitmq-full evalya metric-coverage fixture#25104NouemanKHAL wants to merge 1 commit into
NouemanKHAL wants to merge 1 commit into
Conversation
Add an evalya `rabbitmq-full` task (plus `rabbitmq-standalone`) under rabbitmq/tests, modeled on the redisdb full-coverage fixture. A real management-enabled broker is driven by two workloads so the rabbitmq check and the OTel rabbitmqreceiver report non-trivial values across their whole metric surface: - perf-test: continuous publish/consume/ack (message + queue rate metrics). - activity-gen (pika sidecar): durable queues + persistent messages, queue/exchange and connection/channel churn, unroutable publishes, and messages left ready/unacked (node.* counters, message.dropped, message.current states). A mounted rabbitmq.conf lifts the guest loopback restriction so the workload containers and scrapers can connect over the compose network. README documents that the OTel rabbitmqreceiver disables all node.* metrics by default; a scraping collector must enable them explicitly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
evalya-impact-summaryevalya impact analysis |
Contributor
Validation Report
Run Passed validations (19)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds an evalya
rabbitmq-fullmetric-coverage fixture (plusrabbitmq-standalone) underrabbitmq/tests, modeled on theredisdbfull-coverage fixture. It stands up a real broker under load so the rabbitmq check and the OTelrabbitmqreceiverreport non-trivial values across their whole metric surface — for use by semantic-core OTel↔DD equivalence verification.Motivation
Verifying the rabbitmq OTel↔DD metric equivalences needs both collection paths (Datadog Agent and OTel Collector) scraping the same broker with every mapped metric populated. An idle broker reports zero for most rate/counter metrics, so a dedicated workload fixture is required.
What
Under
rabbitmq/tests/:evalya.yaml—rabbitmq-standalone(the existing compose) andrabbitmq-full.compose/full-coverage.compose— broker + two workloads:pivotalrabbitmq/perf-test): continuous publish/consume/ack →message.*,consumer.count,queue.*rates.pikasidecar): durable queues + persistent messages, queue/exchange + connection/channel churn, unroutable publishes, ready/unacked messages →node.*counters,message.dropped,message.currentstates.compose/config/rabbitmq.conf— lifts theguestloopback restriction so network clients can connect.activity-gen.py,README.md.Validation / Testing
evalya.yamlandfull-coverage.composeparse as valid YAML;activity-gen.pycompiles.generateStage: validate).rabbitmqreceiverdisables allrabbitmq.node.*metrics by default; a scraping collector must enable them explicitly to see roughly half of the mapped metrics.