Skip to content

test(rabbitmq): add rabbitmq-full evalya metric-coverage fixture - #25104

Draft
NouemanKHAL wants to merge 1 commit into
masterfrom
noueman/rabbitmq-evalya-full-coverage
Draft

test(rabbitmq): add rabbitmq-full evalya metric-coverage fixture#25104
NouemanKHAL wants to merge 1 commit into
masterfrom
noueman/rabbitmq-evalya-full-coverage

Conversation

@NouemanKHAL

Copy link
Copy Markdown
Member

TL;DR

Adds an evalya rabbitmq-full metric-coverage fixture (plus rabbitmq-standalone) under rabbitmq/tests, modeled on the redisdb full-coverage fixture. It stands up a real broker under load so the rabbitmq check and the OTel rabbitmqreceiver report non-trivial values across their whole metric surface — for use by semantic-core OTel↔DD equivalence verification.

Motivation

Verifying the rabbitmq OTel↔DD metric equivalences needs both collection paths (Datadog Agent and OTel Collector) scraping the same broker with every mapped metric populated. An idle broker reports zero for most rate/counter metrics, so a dedicated workload fixture is required.

What

Under rabbitmq/tests/:

  • evalya.yamlrabbitmq-standalone (the existing compose) and rabbitmq-full.
  • compose/full-coverage.compose — broker + two workloads:
    • perf-test (pivotalrabbitmq/perf-test): continuous publish/consume/ack → message.*, consumer.count, queue.* rates.
    • activity-gen (pika sidecar): durable queues + persistent messages, queue/exchange + connection/channel churn, unroutable publishes, ready/unacked messages → node.* counters, message.dropped, message.current states.
  • compose/config/rabbitmq.conf — lifts the guest loopback restriction so network clients can connect.
  • activity-gen.py, README.md.

Validation / Testing

  • evalya.yaml and full-coverage.compose parse as valid YAML; activity-gen.py compiles.
  • Fixture bring-up / metric flow to be validated by the evalya CI (generateStage: validate).
  • Note documented in the README: the OTel rabbitmqreceiver disables all rabbitmq.node.* metrics by default; a scraping collector must enable them explicitly to see roughly half of the mapped metrics.

Add an evalya `rabbitmq-full` task (plus `rabbitmq-standalone`) under
rabbitmq/tests, modeled on the redisdb full-coverage fixture.

A real management-enabled broker is driven by two workloads so the
rabbitmq check and the OTel rabbitmqreceiver report non-trivial values
across their whole metric surface:

- perf-test: continuous publish/consume/ack (message + queue rate metrics).
- activity-gen (pika sidecar): durable queues + persistent messages,
  queue/exchange and connection/channel churn, unroutable publishes, and
  messages left ready/unacked (node.* counters, message.dropped,
  message.current states).

A mounted rabbitmq.conf lifts the guest loopback restriction so the
workload containers and scrapers can connect over the compose network.

README documents that the OTel rabbitmqreceiver disables all node.*
metrics by default; a scraping collector must enable them explicitly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 3, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 14 Pipeline jobs failed

PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.11-mgmt), py3.13-3.11-mgmt) / RabbitMQ (py3.13-3.11-mgmt)-py3.13-3.11-mgmt — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Linting failed! Please update to the latest version of ddev to ensure you are using the latest linting rules and then run 'ddev test --fmt rabbitmq' to fix formatting issues.

PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.11-openmetrics), py3.13-3.11-openmetrics) / RabbitMQ (py3.13-3.11-openmetrics)-py3.13-3.11-openmetrics — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Linting failed due to code formatting issues in tests/activity-gen.py. To fix, run 'ddev test --fmt'.

PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.7-mgmt), py3.13-3.7-mgmt) / RabbitMQ (py3.13-3.7-mgmt)-py3.13-3.7-mgmt — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Linting failed due to formatting issues in tests/activity-gen.py.

View all 14 failed jobs.

📋 Copy fix prompt
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:

1. Check whether you already have the Datadog software-delivery MCP tools
   (e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
   anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
   server and skills by following:
     https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
   then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.

Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.

If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.

Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:

1. Locate the change. Diff this branch against its base and find the change
   that produces this error. Explain the mechanism, don't just name a file:
     git fetch origin && git diff $(git merge-base origin/master HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
   proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
   not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
   so plainly instead of "fixing" it — that is a flaky test, and patching it
   hides the problem.

If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).

Branch: noueman/rabbitmq-evalya-full-coverage

PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.11-mgmt), py3.13-3.11-mgmt) / RabbitMQ (py3.13-3.11-mgmt)-py3.13-3.11-mgmt
Commit: 1a3bc058ef45ad33e48a10088c95780e21283d8d
Error (code / quality):
Linting failed! Please update to the latest version of ddev to ensure you are using the latest linting rules and then run 'ddev test --fmt rabbitmq' to fix formatting issues.
CI job: https://github.com/DataDog/integrations-core/actions/runs/33771131485/job/100701476325

PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.11-openmetrics), py3.13-3.11-openmetrics) / RabbitMQ (py3.13-3.11-openmetrics)-py3.13-3.11-openmetrics
Commit: 1a3bc058ef45ad33e48a10088c95780e21283d8d
Error (code / quality):
Linting failed due to code formatting issues in tests/activity-gen.py. To fix, run 'ddev test --fmt'.
CI job: https://github.com/DataDog/integrations-core/actions/runs/33771131485/job/100701476288

PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.7-mgmt), py3.13-3.7-mgmt) / RabbitMQ (py3.13-3.7-mgmt)-py3.13-3.7-mgmt
Commit: 1a3bc058ef45ad33e48a10088c95780e21283d8d
Error (code / quality):
Linting failed due to formatting issues in tests/activity-gen.py.
CI job: https://github.com/DataDog/integrations-core/actions/runs/33771131485/job/100701476386

Plus 9 more failing jobs not shown here.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1a3bc05 | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   4 (always emitted)
Diff (5 files):
  rabbitmq/tests/README.md
  rabbitmq/tests/activity-gen.py
  rabbitmq/tests/compose/config/rabbitmq.conf
  rabbitmq/tests/compose/full-coverage.compose
  rabbitmq/tests/evalya.yaml

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@dd-octo-sts

dd-octo-sts Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
license-headers Validate Python files have proper license headers
qa-label Validate the pull request declares whether it needs QA for the next Agent release

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (19)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant