Document the Redis Sentinel failover event - #3104
Open
philjlee wants to merge 1 commit into
Open
Conversation
The check calls self.event() when a monitored master's IP changes, guarded so it does not fire on the first observation of a master (redis_sentinel.py). The README claimed no events were emitted and the manifest declared creates_events: false; both now match the check. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jeff-morgan-dd
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: TXP-277
Follow-up to #3101, which added a
redis-sentinel-eventsdataflow. That PR surfaced two pieces of metadata that contradict the check's actual behavior. This PR corrects both. No code change.The check does emit events
_process_master_statscallsself.event(...)when a monitored master's IP changes, guarded byif self._masters[master_name] != ""so it does not fire on the first observation of a master:What was wrong
README.mdmanifest.json"creates_events": false"creates_events": trueThe
manifest.jsonhalf was caught by Codex review on this branch: leavingcreates_events: falsewhile the README documents events would keep catalog pages and any manifest-reading tooling advertising that the integration has no events.creates_events: truematches what other event-emitting integrations in this repo declare (cloudsmith,redisenterprise,cybersixgill_actionable_alerts).🤖 Generated with Claude Code