Skip to content

Document the Redis Sentinel failover event - #3104

Open
philjlee wants to merge 1 commit into
masterfrom
philip.lee/TXP-277-redis-sentinel-readme-events
Open

Document the Redis Sentinel failover event#3104
philjlee wants to merge 1 commit into
masterfrom
philip.lee/TXP-277-redis-sentinel-readme-events

Conversation

@philjlee

@philjlee philjlee commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Jira: TXP-277

Follow-up to #3101, which added a redis-sentinel-events dataflow. That PR surfaced two pieces of metadata that contradict the check's actual behavior. This PR corrects both. No code change.

The check does emit events

_process_master_stats calls self.event(...) when a monitored master's IP changes, guarded by if self._masters[master_name] != "" so it does not fire on the first observation of a master:

if self._masters[master_name] != stats['ip']:
    if self._masters[master_name] != "":  # avoid check initialization
        self.increment('redis.sentinel.failover', tags=base_tags)
        self.event({... 'msg_title': '%s failover from %s to %s' ...})

What was wrong

File Was Now
README.md "The Redis's Sentinel check does not include any events." Describes the failover event and the initialization guard
manifest.json "creates_events": false "creates_events": true

The manifest.json half was caught by Codex review on this branch: leaving creates_events: false while the README documents events would keep catalog pages and any manifest-reading tooling advertising that the integration has no events.

creates_events: true matches what other event-emitting integrations in this repo declare (cloudsmith, redisenterprise, cybersixgill_actionable_alerts).

🤖 Generated with Claude Code

The check calls self.event() when a monitored master's IP changes,
guarded so it does not fire on the first observation of a master
(redis_sentinel.py). The README claimed no events were emitted and the
manifest declared creates_events: false; both now match the check.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@philjlee
philjlee requested review from a team as code owners August 10, 2026 14:59
@jeff-morgan-dd jeff-morgan-dd self-assigned this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants