feat(telemetry)!: make telemetry worker wasm-compatible for the TraceExporter#2172
Open
Aaalibaba42 wants to merge 19 commits into
Open
feat(telemetry)!: make telemetry worker wasm-compatible for the TraceExporter#2172Aaalibaba42 wants to merge 19 commits into
Aaalibaba42 wants to merge 19 commits into
Conversation
Aaalibaba42
force-pushed
the
jwiriath/telemetry-wasm
branch
from
June 29, 2026 12:09
1624706 to
9042d85
Compare
|
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportTracked Clippy
By file and crateBy file
By crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. Panic-inducing macros in particular should be avoided. In the future, this report may become a PR-blocking quality gate. |
Contributor
🔒 Cargo Deny Results📦
|
Aaalibaba42
force-pushed
the
jwiriath/telemetry-wasm
branch
from
June 29, 2026 12:13
9042d85 to
6743d39
Compare
Aaalibaba42
marked this pull request as ready for review
June 29, 2026 13:42
Eldolfin
reviewed
Jul 1, 2026
Aaalibaba42
force-pushed
the
jwiriath/telemetry-wasm
branch
3 times, most recently
from
July 1, 2026 12:06
0d19b82 to
ca34406
Compare
Aaalibaba42
force-pushed
the
jwiriath/telemetry-wasm
branch
from
July 1, 2026 12:24
ca34406 to
800823d
Compare
VianneyRuhlmann
requested changes
Jul 1, 2026
VianneyRuhlmann
left a comment
VianneyRuhlmann
left a comment
Contributor
There was a problem hiding this comment.
The change in shutdown_worker really needs to be discussed further as it can negatively impact shutdown time. Also a lot of comment are very verbose and at wasm specific explanation on public methods doc that shouldn't be cluttered with implementation details.
Contributor
Author
We can always have the previous native implementation as is in a |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: waiting
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
# What? Client-side stats span concentrator, stats exporter, and all surrounding state management is now compiled and active on `wasm32` targets. # Why? Previously, most of the stats code was gated behind `#[cfg(not(target_arch = "wasm32"))]`, so wasm builds silently skipped stats computation. As we expand wasm support, CSS should work the same as on native. # How? The root blocker was `std::time::SystemTime`, which panics on `wasm32-unknown-unknown`. Replacing it with `web_time::SystemTime` (which delegates to `Date.now()` in a browser/WASI context) unblocks compilation. Once that was fixed, the `cfg` guards on stats functions, structs, and module re-exports were no longer needed and were removed. ## Additional Notes `Duration` is left as `std::time::Duration` — it's purely arithmetic and has no platform dependency. Only `SystemTime`/`UNIX_EPOCH` needed to be swapped.
Aaalibaba42
requested review from
VianneyRuhlmann and
mabdinur
and removed request for
a team
July 2, 2026 14:12
VianneyRuhlmann
approved these changes
Jul 3, 2026
Comment on lines
+73
to
+76
| if req.uri().scheme_str() == Some("file") { | ||
| let (parts, body) = req.into_parts(); | ||
| return write_to_file_endpoint(&parts.uri, body); | ||
| } |
Contributor
There was a problem hiding this comment.
Not blocking since there not using capabilities, but it seems that crashtracker and the reqwest client also bind custom behavior on the file:// scheme so I wonder if patching the telemetry custom behavior in capabilities is the right solution
Contributor
Author
There was a problem hiding this comment.
There is a test in the gitlab pipeline around crashtracking that seems to consistently timeout after thousands of seconds, it's likely a real bug
Contributor
Author
There was a problem hiding this comment.
Not times out, it's OOM killed, it's really weird, it's only aarch64 linux, nothing else...
…JoinSet or Sequential approaches
Aaalibaba42
force-pushed
the
jwiriath/telemetry-wasm
branch
from
July 6, 2026 09:44
c447d2d to
6b0563e
Compare
Aaalibaba42
force-pushed
the
jwiriath/telemetry-wasm
branch
from
July 6, 2026 09:48
6b0563e to
7846115
Compare
BenchmarksComparisonBenchmark execution time: 2026-07-18 05:31:50 Comparing candidate commit 19987a1 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 140 metrics, 0 unstable metrics.
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Port the telemetry stack (
libdd-telemetry,libdd-data-pipeline) to compile and run onwasm32-unknown-unknown.TelemetryWorker,TelemetryWorkerHandle, andTelemetryClientbecome generic over a capability bundleC: HttpClientCapability + SleepCapability; native call sites pin toNativeCapabilities.Why?
Telemetry was previously hard-gated behind
#[cfg(not(target_arch = "wasm32"))]and was a no-op on that target for theTraceExporter.How?
tokio::timecall (sleep, timeout) is replaced by atokio::select!race against<C as SleepCapability>::new().sleep(…), which resolves tosetTimeouton wasm.std::timereplaced byweb-time(Performance.now()/Date.now()on wasm, re-exportsstd::timeon native).tokio::sync::Notify-based async path alongside the existing nativeCondvarsync path.MockClient/file-endpoint logic inhttp_client.rsis deleted and ported toNativeCapabilitiesinlibdd-capabilities-impl.Additional Notes
TelemetryClientBuilder::buildnow returnsResult(was panicking on missing fields) — Rust API break.TelemetryClient::startis now sync viatry_send_msg— Rust API break.typealias pinned toNativeCapabilities.