Skip to content

Disable retries for stats payload sends #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VianneyRuhlmann wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable retries for stats payload sends #2249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e12034
fix(trace-stats): disable retries for stats payload
datadog-bits Jul 17, 2026
aa352ce
test(trace-stats): expect single attempt in fail test
datadog-bits Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions libdd-trace-stats/src/stats_exporter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use libdd_capabilities::{HttpClientCapability, MaybeSend, SleepCapability};
use libdd_common::Endpoint;
use libdd_shared_runtime::Worker;
use libdd_trace_protobuf::pb;
use libdd_trace_utils::send_with_retry::{send_with_retry, RetryStrategy};
use libdd_trace_utils::send_with_retry::{send_with_retry, RetryBackoffType, RetryStrategy};
use libdd_trace_utils::trace_utils::TracerHeaderTags;
use libdd_trace_utils::tracer_metadata::TracerMetadata;
use std::fmt::Debug;
Expand Down Expand Up @@ -248,7 +248,7 @@ impl<Cap: HttpClientCapability + SleepCapability, Con: FlushableConcentrator>
&self.endpoint,
body,
&headers,
&RetryStrategy::default(),
&RetryStrategy::new(0, 0, RetryBackoffType::Constant, None),
Comment thread
VianneyRuhlmann marked this conversation as resolved.
)
.await;

Expand Down Expand Up @@ -464,8 +464,8 @@ mod tests {
send_status.unwrap_err();

assert!(
poll_for_mock_hit(&mut mock, 10, 100, 6, true).await,
"Expected max retry attempts"
poll_for_mock_hit(&mut mock, 10, 100, 1, true).await,
"Expected a single attempt with no retries"
);
}

Expand Down
Loading