NBK-178: accept MCP-compatible relative DDSQL timestamps - #786
Draft
nmuldavin wants to merge 1 commit into
Draft
Conversation
nmuldavin
force-pushed
the
noah.muldavin/nbk-178-pup-ddsql-from-to-accept-mcp-compatible-relative
branch
from
September 1, 2026 21:30
f50b88a to
536a4f2
Compare
Support now-<duration> in the shared time parser used by DDSQL and security findings analysis while preserving existing timestamp formats. Document the accepted forms and cover request envelopes, malformed inputs, and command help.
nmuldavin
force-pushed
the
noah.muldavin/nbk-178-pup-ddsql-from-to-accept-mcp-compatible-relative
branch
from
September 1, 2026 21:56
536a4f2 to
6883b15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
NBK-178 — https://linear.app/datadoghq/issue/NBK-178/pup-ddsql-from-to-accept-mcp-compatible-relative-timestamps
Outcome
Pup accepts MCP-compatible
now-<duration>timestamps for DDSQL envelope bounds while retaining its existing time formats.Scope
ddsql tableandsecurity findings analyzeto accept forms such asnow-24h.--from/--toformats in DDSQL and security findings help.34c24a6.Acceptance
ddsql table --from now-24h --to nowbuilds the corresponding Unix-millisecond v2 envelope.security findings analyzebuilds its existing Advanced Query API envelope from the same timestamp forms.now-24hexample.--fromor--to.Validation
cargo test --all -- --test-threads=1— passed; 1,907 tests after rebasing onto the latest NBK-161: migrate DDSQL execution to public v2 API #785 head.cargo clippy --all-targets -- -D warnings— passed.cargo fmt --check— passed.cargo build— passed.cargo test mcp_compatible_relative_time -- --test-threads=1— passed; parser and both DDSQL request builders exercised.cargo test test_ddsql_time_help_documents_supported_formats -- --test-threads=1— passed.ddsql tablereturnedinvalid --from;security findings analyzereturnedinvalid --to, both before network execution.Not run / automation gaps
cargo audit— unavailable becausecargo-auditis not installed; this change adds no dependencies.Material deviations and decisions
now-<duration>available to other pup commands using that parser; existing semantics are unchanged.mainwith NBK-161: migrate DDSQL execution to public v2 API #785's commits as direct ancestors. Now that NBK-161: migrate DDSQL execution to public v2 API #785 is merged, GitHub shows the child-only four-file diff.Remaining work or conditions