Skip to content

NBK-183: remove dead DDSQL interval and offset flags - #788

Draft
nmuldavin wants to merge 3 commits into
DataDog:mainfrom
nmuldavin:noah.muldavin/nbk-183-pup-remove-dead-ddsql-interval-and-offset-flags
Draft

NBK-183: remove dead DDSQL interval and offset flags#788
nmuldavin wants to merge 3 commits into
DataDog:mainfrom
nmuldavin:noah.muldavin/nbk-183-pup-remove-dead-ddsql-interval-and-offset-flags

Conversation

@nmuldavin

@nmuldavin nmuldavin commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Linear

NBK-183 — https://linear.app/datadoghq/issue/NBK-183/pup-remove-dead-ddsql-interval-and-offset-flags

Outcome

pup ddsql table rejects the dead --interval and --offset flags and directs users to working SQL and time-window controls.

Scope

  • Remove --interval and --offset from DDSQL table parsing, dispatch, implementation signatures, help, and documentation.
  • Preserve --limit and its row_limit request mapping.
  • Preserve the independent pagination offsets on DDSQL schema discovery commands.
  • This PR is stacked on NBK-175: remove redundant DDSQL time-series command #787 (NBK-175); it does not separately modify the removed ddsql time-series surface.

Acceptance

  • pup ddsql table --offset 5 and --interval 60000 exit with an unknown-argument error.
  • Neither removed flag appears in DDSQL table help, DDSQL long help, or docs/COMMANDS.md.
  • Help and docs name OFFSET n LIMIT m, --from/--to, and per-source table-function timestamps, without recommending a WHERE time filter for granularity.
  • Regression tests cover rejection of both flags and their absence from help.
  • Ordered live DDSQL queries with OFFSET 0 LIMIT 3 and OFFSET 5 LIMIT 3 return distinct three-row pages.
  • --limit still parses and is covered mapping to row_limit in the public v2 request.

Validation

  • cargo test test_ddsql_ — 8 focused DDSQL CLI tests passed.
  • cargo test -- --test-threads=1 — all 1,906 tests passed.
  • cargo clippy -- -D warnings — passed.
  • cargo fmt -- --check — passed.
  • Branch binary smoke test — removed flags both exited 2 with unexpected argument.
  • Branch binary live read-only DDSQL probe — ORDER BY ts OFFSET 0 LIMIT 3 and OFFSET 5 LIMIT 3 each returned three rows with different timestamps.
  • Two independent fresh-context reviews — no findings.

Not run / automation gaps

  • cargo auditcargo-audit is not installed locally. This change adds or updates no dependencies.
  • The default parallel cargo test run hit six process-global mock-environment races against unused.local; the serial full suite passed. No affected source or test was changed in response.

Material deviations and decisions

  • Per user direction, this branch is based on the current head of NBK-175 / NBK-175: remove redundant DDSQL time-series command #787 so no separate time-series work is included.
  • Rebased onto NBK-175 commit 19583e2 after it incorporated latest main (4ed3b64). Conflicts preserved NBK-175's removal of stale 5,000-row guidance while retaining NBK-183 pagination/granularity docs and --limit coverage.

Remaining work or conditions

Remove the redundant DDSQL time-series CLI path and direct users to table --limit 5000 for the former row-limit default. Reject the removed subcommand explicitly and remove it from help, docs, and the parity harness.
Remove the explicit 5,000-row replacement guidance and its dedicated parse test per review feedback.
@nmuldavin
nmuldavin force-pushed the noah.muldavin/nbk-183-pup-remove-dead-ddsql-interval-and-offset-flags branch from dc8aeb3 to 6e4ff0d Compare September 1, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant