NBK-183: remove dead DDSQL interval and offset flags - #788
Draft
nmuldavin wants to merge 3 commits into
Draft
Conversation
Remove the redundant DDSQL time-series CLI path and direct users to table --limit 5000 for the former row-limit default. Reject the removed subcommand explicitly and remove it from help, docs, and the parity harness.
Remove the explicit 5,000-row replacement guidance and its dedicated parse test per review feedback.
nmuldavin
force-pushed
the
noah.muldavin/nbk-183-pup-remove-dead-ddsql-interval-and-offset-flags
branch
from
September 1, 2026 21:58
dc8aeb3 to
6e4ff0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
NBK-183 — https://linear.app/datadoghq/issue/NBK-183/pup-remove-dead-ddsql-interval-and-offset-flags
Outcome
pup ddsql tablerejects the dead--intervaland--offsetflags and directs users to working SQL and time-window controls.Scope
--intervaland--offsetfrom DDSQL table parsing, dispatch, implementation signatures, help, and documentation.--limitand itsrow_limitrequest mapping.ddsql time-seriessurface.Acceptance
pup ddsql table --offset 5and--interval 60000exit with an unknown-argument error.docs/COMMANDS.md.OFFSET n LIMIT m,--from/--to, and per-source table-function timestamps, without recommending aWHEREtime filter for granularity.OFFSET 0 LIMIT 3andOFFSET 5 LIMIT 3return distinct three-row pages.--limitstill parses and is covered mapping torow_limitin the public v2 request.Validation
cargo test test_ddsql_— 8 focused DDSQL CLI tests passed.cargo test -- --test-threads=1— all 1,906 tests passed.cargo clippy -- -D warnings— passed.cargo fmt -- --check— passed.unexpected argument.ORDER BY ts OFFSET 0 LIMIT 3andOFFSET 5 LIMIT 3each returned three rows with different timestamps.Not run / automation gaps
cargo audit—cargo-auditis not installed locally. This change adds or updates no dependencies.cargo testrun hit six process-global mock-environment races againstunused.local; the serial full suite passed. No affected source or test was changed in response.Material deviations and decisions
19583e2after it incorporated latestmain(4ed3b64). Conflicts preserved NBK-175's removal of stale 5,000-row guidance while retaining NBK-183 pagination/granularity docs and--limitcoverage.Remaining work or conditions
mainso its GitHub diff contains only NBK-183.