NBK-164: streamline and instrument DDSQL async polling - #790
Closed
nmuldavin wants to merge 1 commit into
Closed
Conversation
nmuldavin
force-pushed
the
noah.muldavin/nbk-164-pup-remove-the-redundant-poll-sleep-bound-and-in
branch
from
September 1, 2026 21:57
8cd5c64 to
1c4452c
Compare
Remove successful-poll sleeps, let AQA terminal states govern total runtime, bound individual HTTP and rate-limit retry waits below server liveness, and emit TTY-only progress on stderr.
nmuldavin
force-pushed
the
noah.muldavin/nbk-164-pup-remove-the-redundant-poll-sleep-bound-and-in
branch
from
September 2, 2026 19:16
1c4452c to
b5fc943
Compare
Contributor
Author
|
Closing this draft because NBK-164 was re-scoped and this implementation no longer matches its requirements. The issue remains active and will be reimplemented separately. |
nmuldavin
deleted the
noah.muldavin/nbk-164-pup-remove-the-redundant-poll-sleep-bound-and-in
branch
September 3, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
NBK-164 — https://linear.app/datadoghq/issue/NBK-164/pup-remove-the-redundant-ddsql-poll-sleep-and-instrument-the-async
Outcome
DDSQL async queries poll without redundant success-path sleeps until AQA returns a terminal state, while individual HTTP and rate-limit waits remain bounded and long waits are reported without contaminating command output.
Scope
Retry-Afterand exponentially retry 429s within a 20-second total retry window, below AOP's 30-second polling-liveness timeout.--timeoutflag.This was developed on top of #785 (NBK-161) and is rebased onto
mainafter that dependency merged.Acceptance
Retry-Afterwith exponential backoff inside a 20-second total retry window.LIMITguidance.Validation
cargo test commands::ddsql::tests --no-fail-fast— 49 DDSQL tests passed, including no-success-sleep, no overall deadline, initial/fetch 429, request timeout, and query-ID diagnostics.cargo clippy --all-targets -- -D warnings— passed.cargo test --no-fail-fast -- --test-threads=1— 1,914 tests passed.cargo fmt --check— passed.git diff --check— passed.Not run / automation gaps
cargo audit— unavailable becausecargo-auditis not installed; this change adds no dependencies.Material deviations and decisions
--timeoutout of scope.Remaining work or conditions