[appsec] accept normalized or raw config name for agentic onboarding telemetry#7337
Merged
christophe-papazian merged 2 commits intoJul 20, 2026
Conversation
Contributor
|
|
christophe-papazian
force-pushed
the
christophe-papazian/agentic-onboarding-telemetry-config-name
branch
from
July 17, 2026 14:44
76dfb83 to
a1488c0
Compare
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 5747fae | Docs | Datadog PR Page | Give us feedback! |
christophe-papazian
marked this pull request as ready for review
July 17, 2026 15:41
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1488c0b37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Strech
approved these changes
Jul 20, 2026
…telemetry Some tracers report telemetry configuration entries under the raw dotted name (appsec.agentic_onboarding) while others (e.g. Java) normalize it to the env-var form (DD_APPSEC_AGENTIC_ONBOARDING, uppercased with dots -> underscores). Accept either, matching the convention used by other telemetry tests (e.g. ["DD_APPSEC_ENABLED", "appsec.enabled"]). Also drops the incorrect "raw key must not be reported" assertions from #7320: the two names are just the raw and normalized forms of the same config, not a forbidden separate entry. Presence-only refers to the env-var's value never being read, not to a second telemetry entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The agentic-onboarding feature is being reworked. Set python to missing_feature to disable the tests everywhere (all other tracers were already missing_feature). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
christophe-papazian
force-pushed
the
christophe-papazian/agentic-onboarding-telemetry-config-name
branch
from
July 20, 2026 13:19
a1488c0 to
5747fae
Compare
christophe-papazian
requested review from
ZStriker19 and
mabdinur
and removed request for
a team
July 20, 2026 13:19
christophe-papazian
enabled auto-merge (squash)
July 20, 2026 13:19
christophe-papazian
deleted the
christophe-papazian/agentic-onboarding-telemetry-config-name
branch
July 20, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APPSEC-69171
Follow-up to #7320. Telemetry config entries are reported under either the raw name (
appsec.agentic_onboarding) or the normalized env-var form (DD_APPSEC_AGENTIC_ONBOARDING, e.g. Java), depending on the tracer — so the test now accepts either, matching the convention used elsewhere (e.g.["DD_APPSEC_ENABLED", "appsec.enabled"]).Also drops the incorrect "raw key must not be reported" assertions: the two names are just the raw and normalized forms of the same config, not a forbidden separate entry.
🤖 Generated with Claude Code