fix: correctly parse 8-digit #RRGGBBAA hex colors#1005
Merged
Conversation
DavidHDev
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hex-to-RGB helpers that use
parseInt(fullHex, 16)with bit shifts incorrectly parse 8-digit hex colors (#RRGGBBAA).The alpha channel is treated as part of the RGB value, causing the color to be shifted (e.g.
#FF0000FFis parsed as(0, 0, 255)instead of(255, 0, 0)).This can happen when users paste colors from design tools or color pickers that export colors in the
#RRGGBBAAformat.Fix:
Parse only the first 6 digits using
.slice(0, 6), following the same approach used inCurvedInput. The alpha channel is ignored, while the RGB values are parsed correctly.Updated components (all variants):
Thanks to @yceffort for spotting this issue during review.