Repository navigation
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 39745564 | Triggered | Generic Password | 46acaab | scripts/test/test_nacos_client_integration.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.ulticode:nacos-api-patched:2.5.1-ulticode-1.Verified locally
Open security review
GitGuardian incident 39745564, occurrence 310810284 remains needs review. Its external check failed on 46acaab. The reported test-source anchor is known, but the precise detector match span has not been obtained, so no false-positive disposition is claimed. The lifecycle correction preserves that source and scanner coverage. No alert is dismissed, ignored or treated as passing, and this PR will not be merged while the review remains unresolved.
Required before readiness
This remains a draft until full CI passes for the exact head. The prior run passed 27 jobs, including actual Trivy upstream inventory recognition, image checks and cold-start/business acceptance, but failed the original-role configuration callback. Those results do not count as a full pass.
The latest fixture separates two required controls: the unchanged AUTH workload must successfully use naming and direct configuration I/O, then receive explicit 403 for one ordinary batch-listen request through the same SDK transport. A separate non-admin principal in a disposable synthetic-only namespace has namespace-wide configuration read and one exact dataId write. It must receive normal SDK callbacks and recover subscriptions after restart. Missing/wrong credentials, bidirectional cross-namespace direct reads and out-of-scope writes must return explicit 403. Callback timeouts remain failures. Production ACLs are unchanged.
Prior full run: https://github.com/DavidHLP/UltiCode/actions/runs/42222847948 . Docker integration is unavailable locally. That run subsequently passed the live auth/callback/reconnect checks and cold-start/business acceptance, but failed the final config post-shutdown health assertion. Exact SDK source shows that health observation can create a new RPC client after close. The lifecycle correction captures original resources before close and requires their shutdown, termination and factory removal; New exact-head validation for 64bfbda is running: https://github.com/DavidHLP/UltiCode/actions/runs/42232574222 . GitGuardian is tracked separately and remains unresolved.
Scope boundary
This repairs the application client API only. The separately pinned Nacos server image is unchanged; its old generated-code risk remains OPEN as SVC-029. Authentication and private-network exposure limits do not substitute for repairing that server-side parser. Original workload batch-listen authorization also remains OPEN as SVC-030. Namespace-wide read is confined to the owned synthetic fixture and is not a production permission fix or proof of original-role callback compatibility. The unchanged pure SDK also retains per-task listener daemon pools, tracked OPEN as SVC-031. The lifecycle gate reports this retention separately and does not claim exhaustive or leak-free shutdown. No merge, publication or deployment is requested by this PR update.