[DEV] Add support for bitwise XOR and OR operations in sanitizer - #176
Merged
Merged
Conversation
- Update _infer_literal_dtype to handle TensorHandle with multiple data elements - Verify dtype consistency across all elements in multi-element cases - Modify from_value to preserve entire array for multi-element TensorHandle - Maintain backward compatibility for single-element cases This fixes crashes when using `tl.interleave` and similar operations that produce TensorHandle objects with multiple internal values.
- Add bitwise_xor (^) and bitwise_or (|) to BINARY_OP_SYMBOL_TABLE - Add handlers for np.bitwise_xor and np.bitwise_or in op_binary_op_overrider - Include bitwise_xor and bitwise_or in OP_SPEC binary operations list This fixes crashes when using bitwise XOR/OR operations in Triton kernels, particularly needed for FP4 to BF16 conversion code.
Collaborator
Author
|
I will rebase this PR after #174 is merged. |
This reverts commit 63e6d3f.
Collaborator
Author
Done. |
Jokeren
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes crashes when using bitwise XOR/OR operations in Triton kernels,
particularly needed for FP4 to BF16 conversion code.
Fixes #175.