[DEV] Add support for join operation in sanitizer - #178
Merged
Merged
Conversation
mark14wu
commented
Sep 26, 2025
mark14wu
commented
Collaborator
- Add Join class to data.py for representing join operations
- Import Join in patch.py and sanitizer.py
- Add mappings for create_join in patch.py
- Implement op_join_overrider in sanitizer to handle join operations
- Add join to BROADCAST_OPS and create spec with proper dtype handling
- Register Join in OP_TYPE_TO_OVERRIDER mapping
- Add NotImplementedError for join in Z3 evaluation (to be implemented later)
- Add Join class to data.py for representing join operations - Import Join in patch.py and sanitizer.py - Add mappings for create_join in patch.py - Implement op_join_overrider in sanitizer to handle join operations - Add join to BROADCAST_OPS and create spec with proper dtype handling - Register Join in OP_TYPE_TO_OVERRIDER mapping - Add NotImplementedError for join in Z3 evaluation (to be implemented later)
This was referenced Sep 26, 2025
Jokeren
reviewed
Sep 26, 2025
| self.dtype_tt = self.ptr.dtype_tt.element_ty | ||
|
|
||
|
|
||
| def _broadcast_dtype(self): |
Member
There was a problem hiding this comment.
These function names better to be consistent, i.e. _dtype or _post but not mixed
Jokeren
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.