Conversation
Release the Triton 3.8 floor from #485. tilelens 3.1.1 on PyPI still declares triton>=3.6.0, but its Gluon modules fail to import on Triton 3.6.
Performance Benchmark
Iterations: 1 warmup + 20 measured |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tilelens3.1.1 on PyPI still declarestriton>=3.6.0, butimport tilelens.core.simulation.gluonfails on Triton 3.6. Version 3.1.2 declarestriton>=3.8.0(from [COMPAT] Require Triton 3.8 #485), so pip will no longer install TileLens next to a Triton it cannot run with.Test Plan
tilelens-3.1.2-py3-none-any.whl,Version: 3.1.2,Requires-Dist: triton>=3.8.0.After merge: tag the merge commit
v3.1.2and publish a GitHub release. The repository is now namedtilelens, so PyPI's trusted publisher fortilelensmust list repositorytilelens(workflowpublish.yml) before the release; the existingtriton-vizentry no longer matches.Related Issues
Follows #485.
Breaking Changes
Installing
tilelens3.1.2 requires Triton 3.8 or newer.Checklist
npm run build:frontendif the PR modified any TypeScript code.