-
Notifications
You must be signed in to change notification settings - Fork 6
Refactor top of sidebar #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client libraries page should be in the developer tools section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree. Right now it's not easy to learn anything about our client libraries on this site, unless you happen to be one of the intro pages. It's not great that people have to navigate to github to learn how to use them, but at least a persistent sidebar link makes them discoverable. For the great majority of developers, finding info on their client library is also an essential part of getting started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page lives under Getting Started, which implies tutorial/onboarding content. But this is pure reference (a catalog of libraries). Users in "getting started" mode expect guidance on which library to pick and how to install it — they get a link list instead.
Recommendation: Move this page to Developer Tools, and add a how-to guide ("How to install a DeepL client library") to this section that includes installation commands for each language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your idea in the abstract... but I don't think people need a guide for how to install each client library. There's not much to say! These instructions are already in the github repos, and I think that's a logical place for them.
On the other hand, I agree that this page is not very getting-started-y as it stands. Beginners won't need to know about out-of-the-box retries etc.
How about this: I could start this off with a couple of paragraphs explaining about what the client libraries are, what they do, where to find documentation and examples. There wouldn't be much. I think the link boxes are still useful. We could then remove/rewrite the "features include" area or put it elsewhere. The rest could be in a "see also" area.