DateTime and DateTimeImmutable constructor does not always throw Exception

Author: ondrejmirtes

build/phpstan.neon

@@ -34,8 +34,6 @@ parameters:
 		- ../tests/PHPStan/Command/IgnoredRegexValidatorTest.php
 		- ../src/Command/IgnoredRegexValidator.php
 	exceptions:
-		uncheckedExceptionRegexes:
-			- '~^Exception$~'
 		uncheckedExceptionClasses:
 			- 'PHPStan\ShouldNotHappenException'
 			- 'Symfony\Component\Console\Exception\InvalidArgumentException'

conf/config.neon

@@ -1025,6 +1025,11 @@ services:
 		tags:
 			- phpstan.broker.dynamicFunctionReturnTypeExtension
 
+	-
+		class: PHPStan\Type\Php\DateTimeConstructorThrowTypeExtension
+		tags:
+			- phpstan.dynamicStaticMethodThrowTypeExtension
+
 	-
 		class: PHPStan\Type\Php\DsMapDynamicReturnTypeExtension
 		tags:

src/Analyser/NodeScopeResolver.php

@@ -2458,15 +2458,9 @@ static function () use ($expr, $rightResult): MutatingScope {
 							$expr->args,
 							$constructorReflection->getVariants()
 						);
-						if ($constructorReflection->getThrowType() !== null) {
-							$throwType = $constructorReflection->getThrowType();
-							if (!$throwType instanceof VoidType) {
-								$throwPoints[] = ThrowPoint::createExplicit($scope, $throwType, $expr, true);
-							}
-						} elseif ($this->implicitThrows) {
-							if ($classReflection->getName() !== \Throwable::class && !$classReflection->isSubclassOf(\Throwable::class)) {
-								$throwPoints[] = ThrowPoint::createImplicit($scope, $expr);
-							}
+						$constructorThrowPoint = $this->getConstructorThrowPoint($constructorReflection, $classReflection, $expr, $expr->class, $expr->args, $scope);
+						if ($constructorThrowPoint !== null) {
+							$throwPoints[] = $constructorThrowPoint;
 						}
 					}
 				} else {
@@ -2720,6 +2714,39 @@ private function getMethodThrowPoint(MethodReflection $methodReflection, MethodC
 		return null;
 	}
 
+	/**
+	 * @param Node\Arg[] $args
+	 */
+	private function getConstructorThrowPoint(MethodReflection $constructorReflection, ClassReflection $classReflection, New_ $new, Name $className, array $args, MutatingScope $scope): ?ThrowPoint
+	{
+		$methodCall = new StaticCall($className, $constructorReflection->getName(), $args);
+		foreach ($this->dynamicThrowTypeExtensionProvider->getDynamicStaticMethodThrowTypeExtensions() as $extension) {
+			if (!$extension->isStaticMethodSupported($constructorReflection)) {
+				continue;
+			}
+
+			$throwType = $extension->getThrowTypeFromStaticMethodCall($constructorReflection, $methodCall, $scope);
+			if ($throwType === null) {
+				return null;
+			}
+
+			return ThrowPoint::createExplicit($scope, $throwType, $new, false);
+		}
+
+		if ($constructorReflection->getThrowType() !== null) {
+			$throwType = $constructorReflection->getThrowType();
+			if (!$throwType instanceof VoidType) {
+				return ThrowPoint::createExplicit($scope, $throwType, $new, true);
+			}
+		} elseif ($this->implicitThrows) {
+			if ($classReflection->getName() !== \Throwable::class && !$classReflection->isSubclassOf(\Throwable::class)) {
+				return ThrowPoint::createImplicit($scope, $methodCall);
+			}
+		}
+
+		return null;
+	}
+
 	private function getStaticMethodThrowPoint(MethodReflection $methodReflection, StaticCall $methodCall, MutatingScope $scope): ?ThrowPoint
 	{
 		foreach ($this->dynamicThrowTypeExtensionProvider->getDynamicStaticMethodThrowTypeExtensions() as $extension) {

src/Command/FixerApplication.php

@@ -387,7 +387,7 @@ private function downloadPhar(
 		);
 
 		/** @var array{url: string, version: string} $latestInfo */
-		$latestInfo = Json::decode((string) await($client->get('https://fixer-download-api.phpstan.com/latest'), $loop, 5.0)->getBody(), Json::FORCE_ARRAY);
+		$latestInfo = Json::decode((string) await($client->get('https://fixer-download-api.phpstan.com/latest'), $loop, 5.0)->getBody(), Json::FORCE_ARRAY); // @phpstan-ignore-line
 		if ($currentVersion !== null && $latestInfo['version'] === $currentVersion) {
 			$this->writeInfoFile($infoPath, $latestInfo['version']);
 			$output->writeln('<fg=green>You\'re running the latest PHPStan Pro!</>');

src/Type/Php/DateTimeConstructorThrowTypeExtension.php

@@ -0,0 +1,45 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Php;
+
+use DateTime;
+use DateTimeImmutable;
+use PhpParser\Node\Expr\StaticCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\DynamicStaticMethodThrowTypeExtension;
+use PHPStan\Type\Type;
+use PHPStan\Type\TypeUtils;
+
+class DateTimeConstructorThrowTypeExtension implements DynamicStaticMethodThrowTypeExtension
+{
+
+	public function isStaticMethodSupported(MethodReflection $methodReflection): bool
+	{
+		return $methodReflection->getName() === '__construct' && in_array($methodReflection->getDeclaringClass()->getName(), [DateTime::class, DateTimeImmutable::class], true);
+	}
+
+	public function getThrowTypeFromStaticMethodCall(MethodReflection $methodReflection, StaticCall $methodCall, Scope $scope): ?Type
+	{
+		if (count($methodCall->args) === 0) {
+			return null;
+		}
+
+		$arg = $methodCall->args[0]->value;
+		$constantStrings = TypeUtils::getConstantStrings($scope->getType($arg));
+		if (count($constantStrings) === 0) {
+			return $methodReflection->getThrowType();
+		}
+
+		foreach ($constantStrings as $constantString) {
+			try {
+				new \DateTime($constantString->getValue());
+			} catch (\Exception $e) { // phpcs:ignore
+				return $methodReflection->getThrowType();
+			}
+		}
+
+		return null;
+	}
+
+}

src/Type/Php/SimpleXMLElementXpathMethodReturnTypeExtension.php

@@ -34,7 +34,7 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
 
 		$argType = $scope->getType($methodCall->args[0]->value);
 
-		$xmlElement = new \SimpleXMLElement('<foo />');
+		$xmlElement = new \SimpleXMLElement('<foo />'); // @phpstan-ignore-line
 
 		foreach (TypeUtils::getConstantStrings($argType) as $constantString) {
 			$result = @$xmlElement->xpath($constantString->getValue());

tests/PHPStan/Rules/Exceptions/CatchWithUnthrownExceptionRuleTest.php

@@ -51,6 +51,14 @@ public function testRule(): void
 				'Dead catch - Throwable is never thrown in the try block.',
 				119,
 			],
+			[
+				'Dead catch - Exception is never thrown in the try block.',
+				171,
+			],
+			[
+				'Dead catch - Exception is never thrown in the try block.',
+				180,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Exceptions/data/unthrown-exception.php

@@ -160,3 +160,35 @@ public function doBar()
 	}
 
 }
+
+class TestDateTime
+{
+
+	public function doFoo(): void
+	{
+		try {
+			new \DateTime();
+		} catch (\Exception $e) {
+
+		}
+	}
+
+	public function doBar(): void
+	{
+		try {
+			new \DateTime('now');
+		} catch (\Exception $e) {
+
+		}
+	}
+
+	public function doBaz(string $s): void
+	{
+		try {
+			new \DateTime($s);
+		} catch (\Exception $e) {
+
+		}
+	}
+
+}