Repository navigation
Proposal: Run git, grep and find helpers with argv instead of a shell #2634
Description
What problem does this solve?
These helpers currently build shell command strings from tool arguments such as search scopes, file patterns and branch names (str_util.c#L246-L270).
Proposed solution
Run the git, grep and find helpers through the existing argv-based subprocess API instead of /bin/sh -c (compat_fs.c#L907-L932). With argv and a minimal environment, those values reach git, grep and find as plain arguments.
Came up while reviewing this project for SafetyCard: https://safetycard.dev/github.com/deusdata/codebase-memory-mcp
Alternatives considered
No response
- I searched existing issues and this is not a duplicate.
Activity
[-]Proposal: Run git, grep and find helpers with argv instead of a shell (SafetyCard review)[/-][+]Proposal: Run git, grep and find helpers with argv instead of a shell[/+]refactor(search): run POSIX unscoped scan as argv stages, no shell (#…
Merge pull request #2749 from tahodev/argv-grep-find-2634
DeusData commentedon Nov 4, 2026
Progress on main: #2749 (merge commit fe55b86) runs the POSIX unscoped search as argv stages feeding the in-process scanner, with no shell. This issue stays open for the git helpers. Thanks again to @tahodev.