fix(cli): add native FreeBSD self-executable path resolution - #1423
Conversation
cbm_detect_self_path had no branch for FreeBSD, falling through to the generic #else that reads /proc/self/exe. In this environment /proc is a native FreeBSD procfs mount left empty (only /compat/linux/proc is populated, for Linux-ABI processes under the compat layer), so the readlink always failed silently and the function fell back to the expected install path instead of the actual running binary's path. This broke install: with no valid self path, the activation transaction could never confirm what to publish and aborted early with "activation transaction I/O failed" before attempting any linkat/rename. Add sysctl(CTL_KERN, KERN_PROC, KERN_PROC_PATHNAME, -1) for FreeBSD, matching the pattern already used in the test suites, and include <sys/sysctl.h> guarded by __FreeBSD__. Signed-off-by: Pedro Ramos <131530838+pr9000@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Merged — thank you @PR9000. Worth noting why this one matters more than its size suggests: Shipping in the next release. |
What does this PR do?
cbm_detect_self_pathhad no branch for FreeBSD, falling through to the generic#elsethat reads/proc/self/exe. In this environment/procis a native FreeBSD procfs mount left empty (only/compat/linux/procis populated, for Linux-ABI processes under the compat layer), so thereadlinkalways failed silently and the function fell back to the expected install path instead of the actual running binary's path.This broke
install: with no valid self path, the activation transaction could never confirm what to publish and aborted early before attempting anylinkat/rename.Add
sysctl(CTL_KERN, KERN_PROC, KERN_PROC_PATHNAME, -1)for FreeBSD insrc/cli/cli.c, matching the pattern already used in the test suites, and include<sys/sysctl.h>guarded by__FreeBSD__.Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)