Skip to content

Relax ancestor ACL requirement for runtime dir (fixes #1621) #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Carnival-z wants to merge 1 commit into from
+7 −1
Closed

Relax ancestor ACL requirement for runtime dir (fixes #1621) #1622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/daemon/ipc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,9 +1387,15 @@ static bool posix_directory_parent_secure(int directory_fd) {
struct stat status;
if (directory_fd < 0 || fstat(directory_fd, &status) != 0 || !S_ISDIR(status.st_mode) ||
!posix_directory_owner_trusted(status.st_uid) ||
!cbm_macos_extended_acl_fd_is_deny_only(directory_fd)) {
) {
return false;
}
/* Note: historically this required ancestors to carry only deny-only ACLs,
* which caused failures on macOS where /private/tmp carries allow-type ACLs.
* Allowing allow-ACLs on ancestors (e.g. /private/tmp) keeps the shared
* tmp area usable while the final cbm-daemon-<uid> directory is still
* hardened (0700 and ACL-cleared) by private_directory_tree_open.
*/
/* #1537: this ANCESTOR check refused any group-write bit, which is the same
* rule #1535 removed on the activation side — and the sibling that decision
* covers but that never got changed. A group-writable ~ or ~/.cache is
Expand Down
Loading