fix(mem): honor explicit worker budget override - #1657
Open
atirna wants to merge 1 commit into
Open
Conversation
Signed-off-by: Atirna <288419661+atirna@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CBM_MEM_BUDGET_MBis resolved before a supervised worker starts, but a worker was then silently reduced to the daemon's equal-share cap. On a 376 GB host with the default four job slots, an explicit 300000 MiB override could still become about 48 GB and hitmem.backpressure.futile.This keeps the aggregate cap for the fraction-derived default, while preserving a valid explicit override (which is still clamped to detected RAM).
Verification
scripts/test.sh --suites mem(51 passed)scripts/lint.shcould not run on this host becausecppcheck,clang-tidy, andclang-formatare not installed.Related to #1654 (override path only; does not close the default-slice or crash-vs-degrade parts)
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci) — unavailable locally