Skip to content

Merge pull request #1 from DeusData/main - #2616

Closed
ankitbuilds99 wants to merge 1 commit into
DeusData:mainfrom
ankitbuilds99:main
Closed

ankitbuilds99 wants to merge 1 commit into
DeusData:mainfrom
ankitbuilds99:main

Conversation

@ankitbuilds99

Copy link
Copy Markdown
Contributor

What does this PR do

What does this PR do?

Checklist

  • Every commit is signed off (git commit -s) — required, CI rejects
    unsigned commits (DCO, see CONTRIBUTING.md)
  • Tests pass locally (make -f Makefile.cbm test)
  • Lint passes (make -f Makefile.cbm lint-ci)
  • New behavior is covered by a test (reproduce-first for bug fixes)

@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@DeusData

Copy link
Copy Markdown
Owner

Thanks for opening this. The current PR has no changed files, and the description is still the template. Was this intended to propose a change upstream, or just synchronize your fork? Please clarify the intended change so we can route it correctly.

@DeusData DeusData added the question Further information is requested label Oct 25, 2026
@DeusData

Copy link
Copy Markdown
Owner

Thank you for opening this, Ankit, and for the interest you have been showing in the project across your pull requests. Sorry it took us a while to get back to this one.

We had a closer look, and this PR does not carry any file changes. Its only commit is the merge that brought our main branch into your fork's main (the "Merge pull request #1 from DeusData/main" sync), and both sides of that merge are already part of our main. Against our current main the diff is empty, so there is nothing here for us to merge. We asked about the intent on Oct 19 and have not heard back, so we are closing it to keep the queue tidy.

Nothing is lost by closing it:

A small tip that avoids this next time: open each pull request from its own topic branch rather than from your fork's main. For example:

  1. Bring your fork's main up to date. The "Sync fork" button on your fork's GitHub page does this without opening a PR anywhere.
  2. Create a branch for the change from that up-to-date main, e.g. git checkout -b fix/short-description
  3. Commit with a sign-off (git commit -s), push that branch to your fork, and open the pull request from that branch.
    That way a fork sync never turns into a separate PR, and each PR carries exactly one change.

If you did mean to propose something here, please open a new PR from a topic branch with a short description of the change, and we will gladly take a look. Thanks again for contributing!

@DeusData DeusData closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants