Skip to content

feat(language): map GLSL compute, geometry and tessellation stages - #2761

Merged
DeusData merged 1 commit into
DeusData:mainfrom
tmonestudio:feat/glsl-stage-mapping
Oct 25, 2026
Merged

DeusData merged 1 commit into
DeusData:mainfrom
tmonestudio:feat/glsl-stage-mapping

Conversation

@tmonestudio

Copy link
Copy Markdown
Contributor

What does this PR do?

Maps the remaining GLSL shader stages: .comp, .geom, .tesc, .tese (glslang stage extensions) now map to GLSL, next to the already-mapped .vert/.frag. Vulkan compute shaders were not indexed.

Split out of #2724 as requested, so each claim can be reviewed on its own.

Known limitation (vendored grammar, not changed here): the GLSL grammar reads qualifier-only layout(...) in; / layout(...) out; lines as parse errors, so a definition right after one of them can be missed.

Checklist

  • Every commit is signed off (git commit -s)
  • Covered by test lang_ext_glsl_other_stages
  • Not re-run locally on this rebased head; relies on CI

🤖 Generated with Claude Code

.comp, .geom, .tesc and .tese are the glslang stage extensions next to the
already-mapped .vert and .frag; Vulkan compute shaders were not indexed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Leonardo trindade miranda <tmonestudio@gmail.com>
Signed-off-by: mbrl <mbrl@local>
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@DeusData
DeusData merged commit 10df7bc into DeusData:main Oct 25, 2026
27 checks passed
@DeusData

Copy link
Copy Markdown
Owner

Thank you, @tmonestudio, for splitting this out so quickly and so cleanly. Mapping .comp, .geom, .tesc and .tese to GLSL closes a real gap: Vulkan compute shaders and the geometry and tessellation stages were invisible to the index until now, and the glslang stage names are exactly the right set. The new entries sit right next to .vert and .frag, the lang_ext_glsl_other_stages test pins all four, and noting the qualifier-only layout(...) in; limitation in the description saves the next reader the same investigation. CI is green on this head and it merges cleanly with current main, so this is now merged. Thanks again, also for the careful follow-through on #2724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants