Repository navigation
feat(language): map GLSL compute, geometry and tessellation stages - #2761
Conversation
.comp, .geom, .tesc and .tese are the glslang stage extensions next to the already-mapped .vert and .frag; Vulkan compute shaders were not indexed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Leonardo trindade miranda <tmonestudio@gmail.com> Signed-off-by: mbrl <mbrl@local>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Thank you, @tmonestudio, for splitting this out so quickly and so cleanly. Mapping .comp, .geom, .tesc and .tese to GLSL closes a real gap: Vulkan compute shaders and the geometry and tessellation stages were invisible to the index until now, and the glslang stage names are exactly the right set. The new entries sit right next to .vert and .frag, the lang_ext_glsl_other_stages test pins all four, and noting the qualifier-only layout(...) in; limitation in the description saves the next reader the same investigation. CI is green on this head and it merges cleanly with current main, so this is now merged. Thanks again, also for the careful follow-through on #2724. |
What does this PR do?
Maps the remaining GLSL shader stages:
.comp,.geom,.tesc,.tese(glslang stage extensions) now map to GLSL, next to the already-mapped.vert/.frag. Vulkan compute shaders were not indexed.Split out of #2724 as requested, so each claim can be reviewed on its own.
Known limitation (vendored grammar, not changed here): the GLSL grammar reads qualifier-only
layout(...) in;/layout(...) out;lines as parse errors, so a definition right after one of them can be missed.Checklist
git commit -s)lang_ext_glsl_other_stages🤖 Generated with Claude Code