Repository navigation
Conversation
The layout writer now combines YYJSON_WRITE_ALLOW_INVALID_UNICODE with YYJSON_WRITE_ESCAPE_UNICODE, replacing malformed bytes with escaped U+FFFD characters and escaping valid non-ASCII text. A regression test checks strict parsing, replacement characters, valid Unicode round trips, and escaping alongside quotes, backslashes, and newlines. It also covers empty layouts, optional fields, and non-finite numeric values. Fixes DeusData#2907 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Open
2 tasks done
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Galaxy and Architecture can fail to draw the graph when layout text contains malformed UTF-8. The layout request returns HTTP 500 with "JSON parse failed". cbm_layout_to_json allowed invalid Unicode, which copied malformed UTF-8 bytes into its output. handle_layout then parsed that output with strict yyjson_read settings and rejected it.
The layout writer now combines YYJSON_WRITE_ALLOW_INVALID_UNICODE with YYJSON_WRITE_ESCAPE_UNICODE, replacing malformed bytes with escaped U+FFFD characters and escaping valid non-ASCII text. A regression test checks strict parsing, replacement characters, valid Unicode round trips, and escaping alongside quotes, backslashes, and newlines. It also covers empty layouts, optional fields, and non-finite numeric values.
Ran
./scripts/test.shlocally on macOS; it was still building the grammar objects when it hit its 599 second time limit, so it reported no test result.Lint (
scripts/lint.sh,scripts/ci/lint-mem.sh) was not run locally.I did not run the new test against the unfixed writer, so this PR does not yet show it failing on the base branch.
Fixes #2907
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)AI was used for assistance.