Repository navigation
Conversation
Fixes DeusData#2585 Signed-off-by: Scott Beck <296871+bline@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence consumers need to identify the publication behind a tool result and distinguish indexed source from a later filesystem read. This implements the remaining observation contract proposed in #2585:
snapshot: trueon query_graph, search_graph, trace_path, get_code_snippet, check_index_coverage and search_code pins the existing database read scope and returns{store_generation, snapshot_consistent: true, data}.datapreserves the original JSON or tree result. Default requests stay unwrapped; failure to establish or retain the pin returns an explicit error. Cross-service traces are refused because they span project stores.This draft proposes the opt-in response contract for maintainer design review. Maintainer direction on the unified observation contract in #2585 remains pending.
search_code now labels match coordinates as live filesystem observations. Full/context source is captured before rendering, verified against the indexed hash, and sliced from those same captured bytes across output-budget retries. Known drift withholds source; legacy unverifiable source stays explicitly unverified. Captures are shared by file path, with a 64 MiB retained-buffer budget and explicit
source_unavailable: "capture_budget"output when exhausted. A bounded temporary builder can exceed the retained quota; the quota is not a process RSS limit.The pin covers indexed structure. It does not make filesystem reads atomic, establish graph completeness, or provide the optional whole-input/build/configuration manifest discussed in the issue.
metadata.generationretains its coverage-recording meaning. Existing per-tool output budgets apply todata; the envelope adds metadata and JSON quoting overhead.Regression coverage exercises all six tools, default and opt-out output, drift despite matching file metadata, writes after capture in full/context modes, a real second SQLite writer publishing during the pinned request, shared-file capture ownership, quota exhaustion and files-mode capture avoidance.
Validation on Linux x86_64:
scripts/test.sh CC=clang CXX=clang++: exit 0; ASan+UBSan, 10,329 passed, 0 failed, 11 skipped across 192 suites, followed by all production-binary guards. MCP phase: 428 passed, 4 skipped.scripts/lint.sh --ci CLANG_FORMAT=clang-format-20 CPPCHECK_JOBS=4 LINT_SRCS=src/mcp/mcp.c LINT_HDRS=src/mcp/mcp_internal.h: exit 0 using the project lint toolchain container.scripts/security-audit.sh, source/test syntax checks andgit diff --check: exit 0. The production tools/list serializer emits 21,336 bytes, below the existing 21,504-byte ceiling.Full
scripts/lint.shremains non-green: clang-tidy reports existing large-handler complexity and NULL-server dispatch paths. The NULL-server paths follow unchanged baseline handlers; this PR preserves the valid-server behavior. No check suppression, threshold or allocation-baseline changes were made.AI disclosure: implemented with Codex; retained read-only Claude and Astra xhigh reviews were used for correctness feedback. Model review is separate from the executed checks above.
Fixes #2585