🎨 Palette: Add keyboard accessibility to interactive cards#48
Conversation
Co-authored-by: Dev22603 <92785712+Dev22603@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for dev-bachani ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
💡 What:
Added explicit keyboard support to
ExperienceCardandProjectCard. Thesediv/motion.divcomponents behave like buttons but previously relied on mouse clicks. Added semantic roles (role="button"), tab indices (tabIndex={0}),onKeyDownhandlers for Enter and Space (while correctly ignoring clicks on inner interactive tags), and visible focus states usingfocus-visible.Also addressed necessary build configuration errors preventing basic CI checks from running locally (like fixing ESLint's unused vars regex for
motion, resolving Vite's__dirnamemapping, and CSS import order).🎯 Why:
Screen reader and keyboard users were unable to access the modal details or links triggered by these cards, severely hindering site navigation and accessibility.
📸 Before/After:
Keyboard users can now clearly see when a card has focus due to the new primary-color focus ring (
focus-visible:ring-[var(--color-primary)]). (Media verification completed).♿ Accessibility:
role="button"and descriptivearia-labels to custom interactive cards.PR created automatically by Jules for task 4689019616634331141 started by @Dev22603