Skip to content

Update min vue version - #36312

Open
dxvladislavvolkov wants to merge 10 commits into
DevExpress:mainfrom
dxvladislavvolkov:update-min-vue-version
Open

dxvladislavvolkov wants to merge 10 commits into
DevExpress:mainfrom
dxvladislavvolkov:update-min-vue-version

Conversation

@dxvladislavvolkov

Copy link
Copy Markdown
Contributor

No description provided.

@dxvladislavvolkov dxvladislavvolkov self-assigned this Nov 16, 2026
Copilot AI balanced review requested due to automatic review settings November 16, 2026 12:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The lockfile removes all platform bindings for a Rolldown version still used by Vite, causing affected builds and tests to fail after a clean frozen-lockfile installation.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

Raises the DevExtreme Vue wrapper’s minimum supported Vue version to 3.5 and updates development dependencies, demos, and tests to match.

Changes:

  • Updates Vue dependencies to 3.5.45 and refreshes related compiler, router, testing, and build tools.
  • Adapts wrapper tests to updated component typings and rendering timing.
  • Refreshes the workspace lockfile.
File Description
pnpm-lock.yaml Updates resolved dependencies and transitive package records.
packages/​devextreme-vue/​src/​core/​__tests__/​toolbar.test.ts Waits for rendering before asserting template output.
packages/​devextreme-vue/​src/​core/​__tests__/​textbox.test.ts Updates component typings and corrects a Boolean prop declaration.
packages/​devextreme-vue/​src/​core/​__tests__/​selectbox.test.ts Adds explicit component-instance typing.
packages/​devextreme-vue/​src/​core/​__tests__/​form.test.ts Adds explicit component-instance typing.
packages/​devextreme-vue/​src/​core/​__tests__/​data-grid.test.ts Updates typing for grid instance access.
packages/​devextreme-vue/​src/​core/​__tests__/​component.test.ts Updates helper and component lookup typings.
packages/​devextreme-vue/​package.json Raises the Vue peer requirement and updates development tools.
e2e/​wrappers/​package.json Updates Vue for wrapper integration tests.
apps/​vue/​package.json Updates the Vue playground dependency.
apps/​demos/​package.json Updates Vue and related demo compilation tools.

Review effort: Balanced

Comment thread pnpm-lock.yaml
@@ -33162,22 +32868,6 @@ snapshots:
dependencies:
'@oxc-project/types': 0.154.0
'@rolldown/pluginutils': 1.0.1
Copilot AI balanced review requested due to automatic review settings November 17, 2026 10:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The lockfile removes Rolldown 1.2.14’s native binding dependencies and records while active Vite dependencies still require it, causing affected builds and tests to fail after a clean frozen-lockfile install.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 17, 2026 12:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The lockfile removes Rolldown 1.2.14’s native-binding dependencies while Vite still requires that version, causing clean frozen-lockfile installs to break affected builds and Vitest runs.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

ajivanyandev
ajivanyandev previously approved these changes Nov 17, 2026
Copilot AI balanced review requested due to automatic review settings November 18, 2026 09:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The lockfile removes Rolldown 1.2.14’s native bindings while retained Vite snapshots still depend on it, causing affected build and test commands to fail after a clean frozen-lockfile install.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 09:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The lockfile removes all native bindings for Rolldown 1.2.14 while Vite still depends on it, causing clean frozen-lockfile installs to break affected builds and tests.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 19, 2026 06:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the Vue 3.5 dependency and test updates.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants